From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44B8818F2EF for ; Mon, 17 Jun 2024 19:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718654271; cv=none; b=JR8aDLF1IP2EvSE9rElGBNZkNk5c5M2iHyUPhqKXdE+tXFh1okDgw9erzdHz11Rh80YAwZG8Q/A3a3Vgub10Q5M4xHFO0hOE2CabmFicXkU9Nvx1GVp5BWV5L3qIyUEPU9AVYQiMI8aaZg8ycP69ev55JyvXFLgtCa/K0OvSCgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718654271; c=relaxed/simple; bh=KI/Vs+OzdclbQ+l93+Oju2kPh/pOfc8V8i1zsn3rIjI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H628yXmOcyQw7LguWxcb/YJXUXudF5bF39i+iwHPp0gpR6EyWLBiLp0mIZAgFJQaWCZbWzydDzf6MomTVdKPSpvm3YRPWtrjwBaOCWJGQ+6yqLR7Xv8CHWfl8YRFL6dzdh6l5nB2wX1RPtoKB303t7aogxtSO4MDvRbsi26fc5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJIU0-0006BX-5F; Mon, 17 Jun 2024 21:57:40 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJITz-0033XS-J5; Mon, 17 Jun 2024 21:57:39 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sJITz-00GGNG-1b; Mon, 17 Jun 2024 21:57:39 +0200 Date: Mon, 17 Jun 2024 21:57:39 +0200 From: Oleksij Rempel To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Dent Project , kernel@pengutronix.de Subject: Re: [PATCH net-next v3 5/7] net: ethtool: Add new power limit get and set features Message-ID: References: <20240614-feature_poe_power_cap-v3-0-a26784e78311@bootlin.com> <20240614-feature_poe_power_cap-v3-5-a26784e78311@bootlin.com> <20240617181413.12178f95@kmaincent-XPS-13-7390> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240617181413.12178f95@kmaincent-XPS-13-7390> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Mon, Jun 17, 2024 at 06:14:13PM +0200, Kory Maincent wrote: > > +------------------------------------------+--------+----------------------------+ > > | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_RANGES`` | nested | array of power > > limit ranges| > > +-+----------------------------------------+--------+----------------------------+ > > | | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_RANGE_ENTRY`` | nested | one power > > limit range | > > +-+-+--------------------------------------+--------+----------------------------+ > > | | | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_MIN`` | u32 | minimum power value > > (mW) | > > +-+-+--------------------------------------+--------+----------------------------+ > > | | | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_MAX`` | u32 | maximum power value > > (mW) | > > +-+-+--------------------------------------+--------+----------------------------+ > > Not sure the ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_RANGE_ENTRY bring anything > interesting. > > +--------------------------------------------+--------+----------------------------+ > | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_RANGES`` | nested | array of power limit ranges| > +-+------------------------------------------+--------+----------------------------+ > | | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_MIN`` | u32 | minimum power value (mW) | > +-+------------------------------------------+--------+----------------------------+ > | | ``ETHTOOL_A_C33_PSE_PWR_VAL_LIMIT_MAX`` | u32 | maximum power value (mW) | > +-+------------------------------------------+--------+----------------------------+ Ack. Good point. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |