Re: [PATCH] Fix misspelling of "accept*"

Re: [PATCH] Fix misspelling of "accept*"

[Dr. David Alan Gilbert]

* Alexander Zubkov (green@qrator.net) wrote:
> Several files have "accept*" misspelled as "accpet*" in the comments.
> Fix all such occurrences.
> 
> Signed-off-by: Alexander Zubkov <green@qrator.net>

Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>

hmm, should probably cc in some maintainers, I guess networking.
(added netdev and Paolo)

Dave

> ---
>  drivers/infiniband/hw/irdma/cm.c                              | 2 +-
>  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c | 4 ++--
>  drivers/net/ethernet/natsemi/ns83820.c                        | 2 +-
>  include/uapi/linux/udp.h                                      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> index 36bb7e5ce..ce8d821bd 100644
> --- a/drivers/infiniband/hw/irdma/cm.c
> +++ b/drivers/infiniband/hw/irdma/cm.c
> @@ -3631,7 +3631,7 @@ void irdma_free_lsmm_rsrc(struct irdma_qp *iwqp)
>  /**
>   * irdma_accept - registered call for connection to be accepted
>   * @cm_id: cm information for passive connection
> - * @conn_param: accpet parameters
> + * @conn_param: accept parameters
>   */
>  int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
>  {
> diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> index 455a54708..96fd31d75 100644
> --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> @@ -342,8 +342,8 @@ static struct sk_buff *copy_gl_to_skb_pkt(const struct pkt_gl *gl,
>  {
>  	struct sk_buff *skb;
>  
> -	/* Allocate space for cpl_pass_accpet_req which will be synthesized by
> -	 * driver. Once driver synthesizes cpl_pass_accpet_req the skb will go
> +	/* Allocate space for cpl_pass_accept_req which will be synthesized by
> +	 * driver. Once driver synthesizes cpl_pass_accept_req the skb will go
>  	 * through the regular cpl_pass_accept_req processing in TOM.
>  	 */
>  	skb = alloc_skb(gl->tot_len + sizeof(struct cpl_pass_accept_req)
> diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
> index 998586872..bea969dfa 100644
> --- a/drivers/net/ethernet/natsemi/ns83820.c
> +++ b/drivers/net/ethernet/natsemi/ns83820.c
> @@ -2090,7 +2090,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
>  	 */
>  	/* Ramit : 1024 DMA is not a good idea, it ends up banging
>  	 * some DELL and COMPAQ SMP systems
> -	 * Turn on ALP, only we are accpeting Jumbo Packets */
> +	 * Turn on ALP, only we are accepting Jumbo Packets */
>  	writel(RXCFG_AEP | RXCFG_ARP | RXCFG_AIRL | RXCFG_RX_FD
>  		| RXCFG_STRIPCRC
>  		//| RXCFG_ALP
> diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
> index 1a0fe8b15..d85d671de 100644
> --- a/include/uapi/linux/udp.h
> +++ b/include/uapi/linux/udp.h
> @@ -31,7 +31,7 @@ struct udphdr {
>  #define UDP_CORK	1	/* Never send partially complete segments */
>  #define UDP_ENCAP	100	/* Set the socket to accept encapsulated packets */
>  #define UDP_NO_CHECK6_TX 101	/* Disable sending checksum for UDP6X */
> -#define UDP_NO_CHECK6_RX 102	/* Disable accpeting checksum for UDP6 */
> +#define UDP_NO_CHECK6_RX 102	/* Disable accepting checksum for UDP6 */
>  #define UDP_SEGMENT	103	/* Set GSO segmentation size */
>  #define UDP_GRO		104	/* This socket can receive UDP GRO packets */
>  
> -- 
> 2.45.2
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] Fix misspelling of "accept*"

[Alexander Zubkov]

Hi,

I just wanted to kindly check in on the status of my patch. Please let
me know if any further action is needed from my side.

Thanks for your time!

Best regards,
Alexander Zubkov

On Sat, Jun 22, 2024 at 10:14 PM Dr. David Alan Gilbert
<linux@treblig.org> wrote:
>
> * Alexander Zubkov (green@qrator.net) wrote:
> > Several files have "accept*" misspelled as "accpet*" in the comments.
> > Fix all such occurrences.
> >
> > Signed-off-by: Alexander Zubkov <green@qrator.net>
>
> Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> hmm, should probably cc in some maintainers, I guess networking.
> (added netdev and Paolo)
>
> Dave
>
> > ---
> >  drivers/infiniband/hw/irdma/cm.c                              | 2 +-
> >  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c | 4 ++--
> >  drivers/net/ethernet/natsemi/ns83820.c                        | 2 +-
> >  include/uapi/linux/udp.h                                      | 2 +-
> >  4 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> > index 36bb7e5ce..ce8d821bd 100644
> > --- a/drivers/infiniband/hw/irdma/cm.c
> > +++ b/drivers/infiniband/hw/irdma/cm.c
> > @@ -3631,7 +3631,7 @@ void irdma_free_lsmm_rsrc(struct irdma_qp *iwqp)
> >  /**
> >   * irdma_accept - registered call for connection to be accepted
> >   * @cm_id: cm information for passive connection
> > - * @conn_param: accpet parameters
> > + * @conn_param: accept parameters
> >   */
> >  int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
> >  {
> > diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > index 455a54708..96fd31d75 100644
> > --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > @@ -342,8 +342,8 @@ static struct sk_buff *copy_gl_to_skb_pkt(const struct pkt_gl *gl,
> >  {
> >       struct sk_buff *skb;
> >
> > -     /* Allocate space for cpl_pass_accpet_req which will be synthesized by
> > -      * driver. Once driver synthesizes cpl_pass_accpet_req the skb will go
> > +     /* Allocate space for cpl_pass_accept_req which will be synthesized by
> > +      * driver. Once driver synthesizes cpl_pass_accept_req the skb will go
> >        * through the regular cpl_pass_accept_req processing in TOM.
> >        */
> >       skb = alloc_skb(gl->tot_len + sizeof(struct cpl_pass_accept_req)
> > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
> > index 998586872..bea969dfa 100644
> > --- a/drivers/net/ethernet/natsemi/ns83820.c
> > +++ b/drivers/net/ethernet/natsemi/ns83820.c
> > @@ -2090,7 +2090,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
> >        */
> >       /* Ramit : 1024 DMA is not a good idea, it ends up banging
> >        * some DELL and COMPAQ SMP systems
> > -      * Turn on ALP, only we are accpeting Jumbo Packets */
> > +      * Turn on ALP, only we are accepting Jumbo Packets */
> >       writel(RXCFG_AEP | RXCFG_ARP | RXCFG_AIRL | RXCFG_RX_FD
> >               | RXCFG_STRIPCRC
> >               //| RXCFG_ALP
> > diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
> > index 1a0fe8b15..d85d671de 100644
> > --- a/include/uapi/linux/udp.h
> > +++ b/include/uapi/linux/udp.h
> > @@ -31,7 +31,7 @@ struct udphdr {
> >  #define UDP_CORK     1       /* Never send partially complete segments */
> >  #define UDP_ENCAP    100     /* Set the socket to accept encapsulated packets */
> >  #define UDP_NO_CHECK6_TX 101 /* Disable sending checksum for UDP6X */
> > -#define UDP_NO_CHECK6_RX 102 /* Disable accpeting checksum for UDP6 */
> > +#define UDP_NO_CHECK6_RX 102 /* Disable accepting checksum for UDP6 */
> >  #define UDP_SEGMENT  103     /* Set GSO segmentation size */
> >  #define UDP_GRO              104     /* This socket can receive UDP GRO packets */
> >
> > --
> > 2.45.2
> >
> >
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] Fix misspelling of "accept*"

[Dr. David Alan Gilbert]

* Alexander Zubkov (green@qrator.net) wrote:
> Hi,
> 
> I just wanted to kindly check in on the status of my patch. Please let
> me know if any further action is needed from my side.
> 
> Thanks for your time!

I was only a reviewer on this; it'll need some of the netdev people
to notice it for it to get further.

Dave

> Best regards,
> Alexander Zubkov
> 
> On Sat, Jun 22, 2024 at 10:14 PM Dr. David Alan Gilbert
> <linux@treblig.org> wrote:
> >
> > * Alexander Zubkov (green@qrator.net) wrote:
> > > Several files have "accept*" misspelled as "accpet*" in the comments.
> > > Fix all such occurrences.
> > >
> > > Signed-off-by: Alexander Zubkov <green@qrator.net>
> >
> > Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
> >
> > hmm, should probably cc in some maintainers, I guess networking.
> > (added netdev and Paolo)
> >
> > Dave
> >
> > > ---
> > >  drivers/infiniband/hw/irdma/cm.c                              | 2 +-
> > >  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c | 4 ++--
> > >  drivers/net/ethernet/natsemi/ns83820.c                        | 2 +-
> > >  include/uapi/linux/udp.h                                      | 2 +-
> > >  4 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> > > index 36bb7e5ce..ce8d821bd 100644
> > > --- a/drivers/infiniband/hw/irdma/cm.c
> > > +++ b/drivers/infiniband/hw/irdma/cm.c
> > > @@ -3631,7 +3631,7 @@ void irdma_free_lsmm_rsrc(struct irdma_qp *iwqp)
> > >  /**
> > >   * irdma_accept - registered call for connection to be accepted
> > >   * @cm_id: cm information for passive connection
> > > - * @conn_param: accpet parameters
> > > + * @conn_param: accept parameters
> > >   */
> > >  int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
> > >  {
> > > diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > index 455a54708..96fd31d75 100644
> > > --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > @@ -342,8 +342,8 @@ static struct sk_buff *copy_gl_to_skb_pkt(const struct pkt_gl *gl,
> > >  {
> > >       struct sk_buff *skb;
> > >
> > > -     /* Allocate space for cpl_pass_accpet_req which will be synthesized by
> > > -      * driver. Once driver synthesizes cpl_pass_accpet_req the skb will go
> > > +     /* Allocate space for cpl_pass_accept_req which will be synthesized by
> > > +      * driver. Once driver synthesizes cpl_pass_accept_req the skb will go
> > >        * through the regular cpl_pass_accept_req processing in TOM.
> > >        */
> > >       skb = alloc_skb(gl->tot_len + sizeof(struct cpl_pass_accept_req)
> > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
> > > index 998586872..bea969dfa 100644
> > > --- a/drivers/net/ethernet/natsemi/ns83820.c
> > > +++ b/drivers/net/ethernet/natsemi/ns83820.c
> > > @@ -2090,7 +2090,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
> > >        */
> > >       /* Ramit : 1024 DMA is not a good idea, it ends up banging
> > >        * some DELL and COMPAQ SMP systems
> > > -      * Turn on ALP, only we are accpeting Jumbo Packets */
> > > +      * Turn on ALP, only we are accepting Jumbo Packets */
> > >       writel(RXCFG_AEP | RXCFG_ARP | RXCFG_AIRL | RXCFG_RX_FD
> > >               | RXCFG_STRIPCRC
> > >               //| RXCFG_ALP
> > > diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
> > > index 1a0fe8b15..d85d671de 100644
> > > --- a/include/uapi/linux/udp.h
> > > +++ b/include/uapi/linux/udp.h
> > > @@ -31,7 +31,7 @@ struct udphdr {
> > >  #define UDP_CORK     1       /* Never send partially complete segments */
> > >  #define UDP_ENCAP    100     /* Set the socket to accept encapsulated packets */
> > >  #define UDP_NO_CHECK6_TX 101 /* Disable sending checksum for UDP6X */
> > > -#define UDP_NO_CHECK6_RX 102 /* Disable accpeting checksum for UDP6 */
> > > +#define UDP_NO_CHECK6_RX 102 /* Disable accepting checksum for UDP6 */
> > >  #define UDP_SEGMENT  103     /* Set GSO segmentation size */
> > >  #define UDP_GRO              104     /* This socket can receive UDP GRO packets */
> > >
> > > --
> > > 2.45.2
> > >
> > >
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] Fix misspelling of "accept*"

[Simon Horman]

On Sun, Sep 15, 2024 at 04:25:09PM +0000, Dr. David Alan Gilbert wrote:
> * Alexander Zubkov (green@qrator.net) wrote:
> > Hi,
> > 
> > I just wanted to kindly check in on the status of my patch. Please let
> > me know if any further action is needed from my side.
> > 
> > Thanks for your time!
> 
> I was only a reviewer on this; it'll need some of the netdev people
> to notice it for it to get further.

Hi,

Firstly I would suggest splitting the drivers/infiniband change into
a separate patch and sending it to the relevant Infiniband maintainers.
./scripts/get_maintainer.pl will help you find them.

And then posting what as left as a patch for net-next.
For guidance on that please see:
https://docs.kernel.org/process/maintainer-netdev.html

net-next is currently closed, as the merge window is open.
So you will need to wait until net-next reopens before posting
your patch for net-next. That will happen after v6.12-rc1
has been released, most likely a little over two weeks from now.

...