From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
George McCollister <george.mccollister@gmail.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Kory Maincent <kory.maincent@bootlin.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Drop explicit initialization of struct i2c_device_id::driver_data to 0
Date: Wed, 26 Jun 2024 07:00:08 +0200 [thread overview]
Message-ID: <ZnugWNWu35eIy00M@pengutronix.de> (raw)
In-Reply-To: <20240625083853.2205977-2-u.kleine-koenig@baylibre.com>
Hi Uwe,
On Tue, Jun 25, 2024 at 10:38:53AM +0200, Uwe Kleine-König wrote:
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
>
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
>
> While add it, also remove commas after the sentinel entries.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> I'm unsure if I should have split this patch further; per subdir of
> drivers/net or even per driver. If you want it split, please tell me.
>
> Best regards
> Uwe
>
> drivers/net/dsa/lan9303_i2c.c | 2 +-
> drivers/net/dsa/microchip/ksz9477_i2c.c | 4 ++--
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> drivers/net/pse-pd/pd692x0.c | 4 ++--
> drivers/net/pse-pd/tps23881.c | 4 ++--
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-06-26 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 8:38 [PATCH net-next] net: Drop explicit initialization of struct i2c_device_id::driver_data to 0 Uwe Kleine-König
2024-06-25 9:04 ` Petr Machata
2024-06-25 9:50 ` Kory Maincent
2024-06-25 23:56 ` Jeremy Kerr
2024-06-26 5:00 ` Oleksij Rempel [this message]
2024-06-26 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnugWNWu35eIy00M@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=idosch@nvidia.com \
--cc=jk@codeconstruct.com.au \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).