From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E8313AD31 for ; Wed, 26 Jun 2024 05:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719378042; cv=none; b=cPSQ5tL61HeuYvl/adINLhvYrdm+hrFmJ4/3tK5sRayuaDIARBqtDgyJW29+mK+dbljvIxJm38W9/LhCFkU534Buf/o5Cl/wz3G2NfRee7g4lfK5ymarGqrnvJY7AZhMjXdJlIM7hiG9HsUiGNsGn+2ITNUjT403j9unQDXJ7fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719378042; c=relaxed/simple; bh=zo8r24JgeSRv0jIkMxYfscMZuXhJOrZk+3LzRRcnW/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g+EcvUKWsX2rZpz7MjpyscJmluVrS1PVupWsT8vcT2A3vcdp69Mm9AnDIlCjrAugtrca2ihs9MVzzpDB/zo11Z7BhU5+bwOJeyX9cD5+9T/QSWp0PxgHClHlwHuHkQsZlv3CcpJ8dml60pkpJNR1DqGuyNcrXmNdeqqHTApQU8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMKlQ-0007WN-UN; Wed, 26 Jun 2024 07:00:12 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMKlM-0053DI-Np; Wed, 26 Jun 2024 07:00:08 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sMKlM-00FywX-20; Wed, 26 Jun 2024 07:00:08 +0200 Date: Wed, 26 Jun 2024 07:00:08 +0200 From: Oleksij Rempel To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, George McCollister , Ido Schimmel , Petr Machata , Jeremy Kerr , Matt Johnston , Kory Maincent , netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: Drop explicit initialization of struct i2c_device_id::driver_data to 0 Message-ID: References: <20240625083853.2205977-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240625083853.2205977-2-u.kleine-koenig@baylibre.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Hi Uwe, On Tue, Jun 25, 2024 at 10:38:53AM +0200, Uwe Kleine-König wrote: > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named designators. But it's also a nice > cleanup on its own. > > While add it, also remove commas after the sentinel entries. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > I'm unsure if I should have split this patch further; per subdir of > drivers/net or even per driver. If you want it split, please tell me. > > Best regards > Uwe > > drivers/net/dsa/lan9303_i2c.c | 2 +- > drivers/net/dsa/microchip/ksz9477_i2c.c | 4 ++-- Reviewed-by: Oleksij Rempel > drivers/net/pse-pd/pd692x0.c | 4 ++-- > drivers/net/pse-pd/tps23881.c | 4 ++-- Acked-by: Oleksij Rempel Thank you! Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |