From: Michal Kubiak <michal.kubiak@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Yuiko Oshino <yuiko.oshino@microchip.com>,
<kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net v1 1/2] net: phy: microchip: lan87xx: reinit PHY after cable test
Date: Wed, 3 Jul 2024 16:00:22 +0200 [thread overview]
Message-ID: <ZoVZdp8fTOLXuYQe@localhost.localdomain> (raw)
In-Reply-To: <20240703132801.623218-1-o.rempel@pengutronix.de>
On Wed, Jul 03, 2024 at 03:28:00PM +0200, Oleksij Rempel wrote:
> Reinit PHY after cable test, otherwise link can't be established on
> tested port. This issue is reproducible on LAN9372 switches with
> integrated 100BaseT1 PHYs.
>
> Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/phy/microchip_t1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
> index a838b61cd844b..a35528497a576 100644
> --- a/drivers/net/phy/microchip_t1.c
> +++ b/drivers/net/phy/microchip_t1.c
> @@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)
> ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
> lan87xx_cable_test_report_trans(detect));
>
> - return 0;
> + return phy_init_hw(phydev);
> }
>
> static int lan87xx_cable_test_get_status(struct phy_device *phydev,
> --
> 2.39.2
>
>
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2024-07-03 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 13:28 [PATCH net v1 1/2] net: phy: microchip: lan87xx: reinit PHY after cable test Oleksij Rempel
2024-07-03 13:28 ` [PATCH net v1 2/2] net: phy: microchip: lan87xx: do not report SQI if no link Oleksij Rempel
2024-07-03 14:01 ` Michal Kubiak
2024-07-03 18:57 ` Andrew Lunn
2024-07-03 19:26 ` Woojung.Huh
2024-07-03 14:00 ` Michal Kubiak [this message]
2024-07-03 18:48 ` [PATCH net v1 1/2] net: phy: microchip: lan87xx: reinit PHY after cable test Andrew Lunn
2024-07-04 14:52 ` Florian Fainelli
2024-07-04 14:54 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoVZdp8fTOLXuYQe@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).