netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Ambardar <tony.ambardar@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: test_sockmap, use section names understood by libbpf
Date: Wed, 3 Jul 2024 22:03:11 -0700	[thread overview]
Message-ID: <ZoYtD0ZS/T9CbYht@kodidev-ubuntu> (raw)
In-Reply-To: <20240522080936.2475833-1-jakub@cloudflare.com>

Hi Jakub, Daniel,

On Wed, May 22, 2024 at 10:09:36AM +0200, Jakub Sitnicki wrote:
> libbpf can deduce program type and attach type from the ELF section name.
> We don't need to pass it out-of-band if we switch to libbpf convention [1].
> 
> [1] https://docs.kernel.org/bpf/libbpf/program_types.html
> 
> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
> ---
>  .../selftests/bpf/progs/test_sockmap_kern.h   | 17 +++++-----
>  tools/testing/selftests/bpf/test_sockmap.c    | 31 -------------------
>  2 files changed, 9 insertions(+), 39 deletions(-)
> 
[ snip ]

I recently hit some CI errors on kernel-patches/bpf related to veristat
and the test_sockmap BPF object files:

https://github.com/kernel-patches/bpf/actions/runs/9775040227/job/26985293772?pr=7279

I hadn't seen your submission, and after some investigation my own fix
ended up reproducing your patch: <sigh...>

https://github.com/kernel-patches/bpf/pull/7279/commits/9e5bc23d4a3643e6a4733aac431ee425310e03d6

Given it fixes a CI issue for bpf/master, could we backport/apply your
patch there? 

Thanks,
Tony

      parent reply	other threads:[~2024-07-04  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  8:09 [PATCH bpf-next] selftests/bpf: test_sockmap, use section names understood by libbpf Jakub Sitnicki
2024-05-22 10:12 ` Geliang Tang
2024-05-22 10:26   ` Jakub Sitnicki
2024-05-23  6:57     ` Geliang Tang
2024-05-30 21:50 ` patchwork-bot+netdevbpf
2024-07-04  5:03 ` Tony Ambardar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoYtD0ZS/T9CbYht@kodidev-ubuntu \
    --to=tony.ambardar@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).