From: Michal Kubiak <michal.kubiak@intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@kernel.org>, <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Lukasz Czapnik <lukasz.czapnik@intel.com>
Subject: Re: [PATCH iproute2-next 1/3] man: devlink-resource: add missing words in the example
Date: Thu, 4 Jul 2024 15:31:30 +0200 [thread overview]
Message-ID: <ZoakMumZaeSotVoE@localhost.localdomain> (raw)
In-Reply-To: <20240703131521.60284-2-przemyslaw.kitszel@intel.com>
On Wed, Jul 03, 2024 at 03:15:19PM +0200, Przemek Kitszel wrote:
> Add missing "size" and "path" words in the example, as the current example
> is incorrect and will be rejected by the command.
>
> The keywords were missing from very inception of devlink-resource man page
>
> Fixes: 58b48c5d75e2 ("devlink: Update man pages and add resource man")
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> ---
> man/man8/devlink-resource.8 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/man8/devlink-resource.8 b/man/man8/devlink-resource.8
> index 8c3158076a92..c4f6918c9b03 100644
> --- a/man/man8/devlink-resource.8
> +++ b/man/man8/devlink-resource.8
> @@ -63,7 +63,7 @@ devlink resource show pci/0000:01:00.0
> Shows the resources of the specified devlink device.
> .RE
> .PP
> -devlink resource set pci/0000:01:00.0 /kvd/linear 98304
> +devlink resource set pci/0000:01:00.0 path /kvd/linear size 98304
> .RS 4
> Sets the size of the specified resource for the specified devlink device.
> .RE
> --
> 2.39.3
>
>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2024-07-04 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 13:15 [PATCH iproute2-next 0/3] minor improvements to makefile, devlink Przemek Kitszel
2024-07-03 13:15 ` [PATCH iproute2-next 1/3] man: devlink-resource: add missing words in the example Przemek Kitszel
2024-07-04 13:31 ` Michal Kubiak [this message]
2024-07-03 13:15 ` [PATCH iproute2-next 2/3] devlink: print missing params even if an unknown one is present Przemek Kitszel
2024-07-04 13:33 ` Michal Kubiak
2024-07-03 13:15 ` [PATCH iproute2-next 3/3] Makefile: support building from subdirectories Przemek Kitszel
2024-07-03 15:16 ` Stephen Hemminger
2024-07-03 15:28 ` Przemek Kitszel
2024-07-07 16:48 ` David Ahern
2024-07-07 16:50 ` [PATCH iproute2-next 0/3] minor improvements to makefile, devlink patchwork-bot+netdevbpf
2024-07-08 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoakMumZaeSotVoE@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dsahern@kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).