From: Michal Kubiak <michal.kubiak@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Justin Chen <justin.chen@broadcom.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
<bcm-kernel-feedback-list@broadcom.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH net] net: bcmasp: Fix error code in probe()
Date: Thu, 4 Jul 2024 17:49:42 +0200 [thread overview]
Message-ID: <ZobEloyLq0OPShtf@localhost.localdomain> (raw)
In-Reply-To: <ZoWKBkHH9D1fqV4r@stanley.mountain>
On Thu, Jul 04, 2024 at 10:19:44AM -0500, Dan Carpenter wrote:
> Return an error code if bcmasp_interface_create() fails. Don't return
nitpick: redundant space after "fails."
> success.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/broadcom/asp2/bcmasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index a806dadc4196..20c6529ec135 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1380,6 +1380,7 @@ static int bcmasp_probe(struct platform_device *pdev)
> dev_err(dev, "Cannot create eth interface %d\n", i);
> bcmasp_remove_intfs(priv);
> of_node_put(intf_node);
> + ret = -ENOMEM;
> goto of_put_exit;
> }
> list_add_tail(&intf->list, &priv->intfs);
> --
> 2.43.0
>
>
The patch actually fixes an obvious bug.
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2024-07-04 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 15:19 [PATCH net] net: bcmasp: Fix error code in probe() Dan Carpenter
2024-07-04 15:49 ` Michal Kubiak [this message]
2024-07-04 16:02 ` Markus Elfring
2024-07-05 22:49 ` Justin Chen
2024-07-06 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZobEloyLq0OPShtf@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).