netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: "Krzysztof Olędzki" <ole@ans.pl>
Cc: Andrew Lunn <andrew@lunn.ch>, Michal Kubecek <mkubecek@suse.cz>,
	Moshe Shemesh <moshe@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	tariqt@nvidia.com, Dan Merillat <git@dan.merillat.org>
Subject: Re: [PATCH] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28
Date: Mon, 8 Jul 2024 19:28:38 +0300	[thread overview]
Message-ID: <ZowTsiQdTyLJkdc4@shredder.mtl.com> (raw)
In-Reply-To: <c11f42c6-7d65-4292-840b-64f13740379c@ans.pl>

Hi, similar comments as on the other patch. Subject prefix should be
"[PATCH net-next]" instead of "[PATCH]". Need to copy maintainers
according to the output of "scripts/get_maintainer.pl". Missing SoB
(scripts/checkpatch.pl should flag it). I suggest reading the following
before submitting v2:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html
https://docs.kernel.org/process/maintainer-netdev.html

On Sun, Jul 07, 2024 at 08:41:31PM -0700, Krzysztof Olędzki wrote:
> Enable reading additional EEPROM information from high pages such as
> thresholds and alarms on QSFP/QSFP+/QSFP28 modules.
> 
> The fix is similar to a708fb7b1f8dcc7a8ed949839958cd5d812dd939 but given

Need to include the subject of the commit:

"This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
support for EEPROM high pages query") [...]"

> all the required logic already exists in mlx4_qsfp_eeprom_params_set()
> only s/_LEN/MAX_LEN/ is needed.
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Code LGTM

Thanks

  reply	other threads:[~2024-07-08 16:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  6:26 "netlink error: Invalid argument" with ethtool-5.13+ on recent kernels due to "ethtool: Add netlink handler for getmodule (-m)" - 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via netlink? Krzysztof Olędzki
2024-05-21  6:55 ` Michal Kubecek
2024-05-21  7:02   ` Krzysztof Olędzki
2024-05-21  7:16     ` Krzysztof Olędzki
2024-05-21  7:34     ` Michal Kubecek
2024-05-21  7:38       ` Krzysztof Olędzki
2024-05-21 20:21         ` Andrew Lunn
2024-05-22  4:54           ` Krzysztof Olędzki
2024-05-22  8:40             ` Ido Schimmel
2024-05-22 12:44               ` Andrew Lunn
2024-05-23  5:29                 ` Krzysztof Olędzki
2024-05-23 10:37                   ` Michal Kubecek
2024-05-23 10:48                   ` Ido Schimmel
2024-05-23 15:35                   ` Andrew Lunn
2024-07-08  3:41                     ` [PATCH] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28 Krzysztof Olędzki
2024-07-08 16:28                       ` Ido Schimmel [this message]
2024-07-09 11:17                       ` Dan Merillat
2024-07-08  3:41                     ` [PATCH] qsfp: Better handling of Page 03h netlink read failure Krzysztof Olędzki
2024-07-08 16:12                       ` Ido Schimmel
2024-07-31  0:55                         ` Krzysztof Olędzki
2024-07-31  8:48                           ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZowTsiQdTyLJkdc4@shredder.mtl.com \
    --to=idosch@nvidia.com \
    --cc=andrew@lunn.ch \
    --cc=git@dan.merillat.org \
    --cc=mkubecek@suse.cz \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=ole@ans.pl \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).