From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, netdev@vger.kernel.org, andrew@lunn.ch,
danieller@nvidia.com
Subject: Re: [PATCH ethtool-next] module-eeprom: treat zero arguments like any other arguments for hex dump
Date: Sun, 14 Jul 2024 11:39:57 +0300 [thread overview]
Message-ID: <ZpOO3f6qaVWXQ3kY@shredder.mtl.com> (raw)
In-Reply-To: <20240712180706.466124-1-kuba@kernel.org>
On Fri, Jul 12, 2024 at 11:07:06AM -0700, Jakub Kicinski wrote:
> The code does not differentiate between user asking for page 0 and
> page not being set on the CLI at all. This is problematic because
> drivers don't support old type of dumping for newer module types.
> For example trying to hex dump EEPROM of a QSFP-DD on mlx5 gives
> us in kernel logs:
>
> mlx5_query_module_eeprom[...]: Module ID not recognized: 0x18
>
> We can dump all the non-zero pages, and without "hex on" ethtool
> also uses the page-aware API to get the information it will print.
> But hex dumping page 0 is not possible.
>
> Instead of using zero / non-zero to figure out whether param was
> set - add a bitmap of which params got set on command line.
> The nl_param()'s dest option is not used by any other command,
> so we're free to change the format.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
prev parent reply other threads:[~2024-07-14 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 18:07 [PATCH ethtool-next] module-eeprom: treat zero arguments like any other arguments for hex dump Jakub Kicinski
2024-07-14 8:39 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpOO3f6qaVWXQ3kY@shredder.mtl.com \
--to=idosch@nvidia.com \
--cc=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).