From: Joe Damato <jdamato@fastly.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
pabeni@redhat.com, kernel-team@meta.com
Subject: Re: [net PATCH] fbnic: Change kconfig prompt from S390=n to !S390
Date: Thu, 25 Jul 2024 10:17:50 -0700 [thread overview]
Message-ID: <ZqKIvuKvbsucyd2m@LQ3V64L9R2> (raw)
In-Reply-To: <172192698293.1903337.4255690118685300353.stgit@ahduyck-xeon-server.home.arpa>
On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
>
> In testing the recent kernel I found that the fbnic driver couldn't be
> enabled on x86_64 builds. A bit of digging showed that the fbnic driver was
> the only one to check for S390 to be n, all others had checked for !S390.
> Since it is a boolean and not a tristate I am not sure it will be N. So
> just update it to use the !S390 flag.
>
> A quick check via "make menuconfig" verified that after making this change
> there was an option to select the fbnic driver.
>
> Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
[...]
This seems fine to me (and matches other drivers as you mentioned),
but does it need:
Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.")
for it be applied to net?
In either case:
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2024-07-25 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 17:03 [net PATCH] fbnic: Change kconfig prompt from S390=n to !S390 Alexander Duyck
2024-07-25 17:17 ` Joe Damato [this message]
2024-07-25 23:03 ` Alexander Duyck
2024-07-26 17:47 ` Joe Damato
2024-07-27 1:27 ` Jakub Kicinski
2024-07-27 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqKIvuKvbsucyd2m@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox