From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9CEF19048F for ; Tue, 30 Jul 2024 07:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722325084; cv=none; b=WBdga53wdIHsrJ1T89TQkFAL+Ah/N8/eSoVPekZTexRjpswa07eJUhE9kZ5Yg5TnIfSGYaVKl/KRSlNfqT8tC5LparpqaXMc+9qyE00avnii0usqQ06b9lSIS/qHtpMF9rXdHL+ds0SLHjjs3MJW2RlBr9N1v9zupcxLS+Eon6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722325084; c=relaxed/simple; bh=dgwe3Zyf00HyU/NKALavOpwc3sH9BkDEgEGdq/ffgNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hgs2NN98icmAJnVIU3eLsHNjPA0q1BgrvqWSjattHW/gH4mO4lhVcu3MObuu4y90Y4bcwcO7gtbgAOSOvAL6RYwM3tuC6ZsUJEdl5veX5Mg4gxI6y72jremhjZT0R1pG3dOhslNgjhWzQa/f06Si1gT82ygxKm1U7dEQGSgAGLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FckfHNSC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FckfHNSC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4281faefea9so11722255e9.2 for ; Tue, 30 Jul 2024 00:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722325081; x=1722929881; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aP2T6OTy5D0ymvCgcFvi8Du2T0HtVXhOqCElsmNwVHg=; b=FckfHNSC9yfxTkr6hOcL4rletzJXSp3ZARs9t37bIiaIpZ2izleRu31m9zbx7zlpJX Ar2rTBJAo+2D5ID5QYYblNtPwvTQe9FwLnqYHOkhaQwYvg9KXS45digxcoQjbYPTHWMm 0nJohk1mvo9/qqmxjlfzw6nzoUYgy9LW+EIHND6tuxgH5cexzFai3RnDJeKxZVRTVo2o FYzKVzomRaYKnPTRCYx4qhkpr2AMBILxRn9MOabomwXmC7nZdZ7PsZlbcS1ePWoQIn8C ZzQsCbEZbYfzAUsE4nbo5YJq4QtRbVzV/rRvHfe+3tREFnwbsj8tMuV7iwo5Zh9oUmWG M2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722325081; x=1722929881; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aP2T6OTy5D0ymvCgcFvi8Du2T0HtVXhOqCElsmNwVHg=; b=hUnMkph0PgP1u9TxCaBJWgD22rYDsFf6McfSxsQ9060/5aEPe8QlwadS4moCWL/Urc TaLWmFU+IibI65785QEFjkV2A6Q6U5tU3BgrBCBLt6NWgjY/CCzWlltmS5JnCsRedNl5 bptrSjbx3kVow3jHhiOc+V9CCBMQkKUQjcrAtGejKw8pivzVdKED6ff8Mxm05rgwxZIn P4MaDXaV3C9UvQQjSIpfICTEeUImcFpccFLN0Eg32RZx2UiPmZapdIV7SujWuGE3oNx6 PysoltjPm+A0/8A9TuykMLABPBQ0CVWyJDmlzm7uvqbbeBsst0eGV0w1JJKh+1b8ckuw n0Lg== X-Forwarded-Encrypted: i=1; AJvYcCVycT1dptlETpcs0amDnRY3C9Q1Lo2eVbaHiN+4UEOL2LBJghVPkZTZ4jPWIhbyd7TZ2gzvmPavp/+2fc2RDYWNMa3p2ktk X-Gm-Message-State: AOJu0YwvHCgWetZUBdbaI6pNARlsOE8ogPEhQqnPrl7GhAutwL4wasbH CnmrPv1E7F0KlHGOb8gp6YmP9bLnbPJDcC6f/RbNQdkKUp4TbjZzv4VbTtUrFTE= X-Google-Smtp-Source: AGHT+IH35TevswwfKpLXXCRG09T8r9dFas3oFIYyAXN49wr/nzgTnrGSBHThgxAdFiTCtbeYuvSODg== X-Received: by 2002:a05:600c:1d08:b0:426:5f0b:a49b with SMTP id 5b1f17b1804b1-42811e12ce3mr64355815e9.23.1722325080971; Tue, 30 Jul 2024 00:38:00 -0700 (PDT) Received: from localhost (109-81-83-231.rct.o2.cz. [109.81.83.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428057a6307sm203883405e9.36.2024.07.30.00.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 00:38:00 -0700 (PDT) Date: Tue, 30 Jul 2024 09:37:59 +0200 From: Michal Hocko To: Al Viro , Andrew Morton Cc: viro@kernel.org, linux-fsdevel@vger.kernel.org, amir73il@gmail.com, bpf@vger.kernel.org, brauner@kernel.org, cgroups@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: [PATCH 01/39] memcg_write_event_control(): fix a user-triggerable oops Message-ID: References: <20240730050927.GC5334@ZenIV> <20240730051625.14349-1-viro@kernel.org> <20240730071851.GE5334@ZenIV> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730071851.GE5334@ZenIV> I think it can go through Andrew as well. The patch is https://lore.kernel.org/all/20240730051625.14349-1-viro@kernel.org/T/#u On Tue 30-07-24 08:18:51, Al Viro wrote: > On Tue, Jul 30, 2024 at 09:13:38AM +0200, Michal Hocko wrote: > > On Tue 30-07-24 01:15:47, viro@kernel.org wrote: > > > From: Al Viro > > > > > > we are *not* guaranteed that anything past the terminating NUL > > > is mapped (let alone initialized with anything sane). > > > > > > [the sucker got moved in mainline] > > > > > > > You could have preserved > > Fixes: 0dea116876ee ("cgroup: implement eventfd-based generic API for notifications") > > Cc: stable > > > > > Signed-off-by: Al Viro > > > > and > > Acked-by: Michal Hocko > > Will do; FWIW, I think it would be better off going via the > cgroup tree - it's completely orthogonal to the rest of the > series, the only relation being "got caught during the same > audit"... -- Michal Hocko SUSE Labs