From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA97A4D108; Wed, 31 Jul 2024 08:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.81 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722415553; cv=fail; b=HxUmw5106dVRkoE5RQZJuuB0uZ60lOPklS07iGWGNeXHkb2c4mbz726ey08FUwoVpcBfjS19ehK5BH+O6AJuf0LK6tM07r6UHvrT6tuWfHyERx3J9eY0YXfoT8d6TF5jxVWzfmX5sef7/nRJaXyGCyS0qVjLP8Qt2p6ajQpAbFI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722415553; c=relaxed/simple; bh=karRaMKWxy54ft6n+fyriH/oTKk7AVfeL5qW3YksTQM=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=e8KtJy6t+ydFstzOfAPySsAEbnT4clyiaQ83UC+pGncvUymatTsYyH998GXoyz5wKZ0/7Mb+HkAawzKYSV/asGpFZ/HP9QpXZG4UPMJI8GHUb53iWiDJx9h16shtdTOnUBgrFwR8J49Kv/d16PcNbYi6e5Mflaf+1MklD+9hIA4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nBvmD0Yl; arc=fail smtp.client-ip=40.107.223.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nBvmD0Yl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q0aFkFtzv6Z4ji0WK7dp1kHRsFn4fLSCrtTe06NrVXZkFm1eaRrbsAmqXiQflRuMCngem81OUWNDE6+G2zdpM4M+eJM69yl1CdLkFMOAEWrGLYDM8WJsqP7e8LojC4JJANMDx0eyMufL6Hzds4r/KWilTiZFfJmwzpxWabpTzvXrSIuMQvyv7HxffWsV+86CstsTx8kp9IyEQC47x+eVwUhxLFsGfX/mIQtrIUuUcAnV2Cip37C3S5VtSk0cbAUHdAfdCrTlbCb+lu3hMYXAIGUvu1RyqjjgCWjUy4BtpM3KYq/uUEPQmRZMI6wyxRgpWKwfuA7ekvvjNDiYmhfKxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7VcCOUNkIho8v6V8sbmtKn26GIMnCbMEJ9rWF9E3Qc=; b=gB1UIJ6RgQimx8KZv5EB0tUDqbH8JjPKyQgVhbgLGneYLCmuyzdon2AJZlBXBKUaPC+PYIB3ehtD84RFTfKtI0PzGhFcvzGUskZJAkNLE1y38PRYDCLq2EL7z+h7OH9gnuSE/9J/foGLvKmKpIsKKagMpmJs7VUsIi0qCsgWS53TDDnllJ2fyhY5WdD8NIkTX7q6JLaAzvysDGbmWBPfQ+xOHO/dR0/JEJb14NZ9qqe/VBl1E02ONI6ob2eOwSHnwljGouRRVqCylNgKi3layHgJp9Hqi/yAdiRBUs4b+YeWu034M8i/w64prF/6x9EZPOwtv8TWWSJe00EQGqlylw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7VcCOUNkIho8v6V8sbmtKn26GIMnCbMEJ9rWF9E3Qc=; b=nBvmD0YlWaWvHKLORzA+eoiUK9I9OxEx5DkRq/vebPCwICXs0HoU2Q7qfm8qm9EZGQrx3ETFT2Qfibrtn5fWRm5DpvDIbddP9fBriC81A0EhtFQI2o7kt/ldvEly2z0qNOQFLmiPaANUaZOj8GRdqT1KTVIRyEG9EzZ0M1rX0mhqFLL9FYuYY1cnVWrydx2MD/Jma9vaxtjG2LMgmTeuOWfx1tBrTdWTS8E5eOs705iPUSs1y0XIjWBsBrCTpcpbPn75gH+fy7koVs7wB1956ZnJrgrcgjuvFYMlsFsg7TFHfgzARBqg6PpqU57P7phLE/TSk3/hOZfeP3T0GngnzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) by PH0PR12MB7471.namprd12.prod.outlook.com (2603:10b6:510:1e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.28; Wed, 31 Jul 2024 08:45:48 +0000 Received: from CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::9ec8:2099:689a:b41f]) by CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::9ec8:2099:689a:b41f%5]) with mapi id 15.20.7807.026; Wed, 31 Jul 2024 08:45:48 +0000 Date: Wed, 31 Jul 2024 11:45:36 +0300 From: Ido Schimmel To: Krzysztof =?utf-8?Q?Ol=C4=99dzki?= Cc: Tariq Toukan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, Dan Merillat , Moshe Shemesh , Michal Kubecek , Andrew Lunn Subject: Re: [PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28 Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: TL2P290CA0013.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:2::7) To CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6179:EE_|PH0PR12MB7471:EE_ X-MS-Office365-Filtering-Correlation-Id: 985d04f0-970a-472e-7805-08dcb13d2c9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ajl3Rjd5dVBvL1psNk50Z2tHcGY5T0dRcnY4ZXVmSy9VNTBvZkt6dXNIWUh1?= =?utf-8?B?Q2kzRVpjNDJQelRFMTFrN2FhN2gyemczU3VqYU40SEFteDYxNVd5NnhsMnF4?= =?utf-8?B?ZHlJOC9lbHJlNktQdmcxZm9HRTlmMmZ6MW5PTFQveWlaT1pGSHBKRGZ2c1R0?= =?utf-8?B?OHR5N0orakV5VE9yZk5rSXhhZUdEMFBqTXM0cmR0U3dwd0grQ2NLc3pJM2NQ?= =?utf-8?B?L3J4dGRaYjNwRU9KSDJqanJSS3pMRWFSVnRnbzlyaEIyQ2hiMzFmbmxxWXVQ?= =?utf-8?B?b1B5RjJtTGtVYVB5TXM3ZFBTTlNscTcwMVg4RFdTbEcrL0licUJvTWs3RStq?= =?utf-8?B?V3pRTDBrRVZwanVzQm1OQTk0eFp6dFRiQnJkd1J0RFhBR28rWWxQdjBla3dY?= =?utf-8?B?S3A0SnRSejlpMXlTT1lqTlBZbE9pWis3c091ZDlTejRFSFIzUm8wWkVPRXE0?= =?utf-8?B?N0t2MndkNzhPdmJ4d280SytNRG9NUk5KSGFVaGFnUzA2RGo2M1BuZCtHbWZt?= =?utf-8?B?ZVpiNVZVODQxMXNrbEwxV3ZPWGIzVDZicU14U0kxTi9IeHpTNmF1cU5CdDMr?= =?utf-8?B?VW5UeWEvMHlYOHRxaUZWUkNUVDlIckN5bXN5UEsvZkhqNlZEaHJPQUtwejEw?= =?utf-8?B?SjFlZnZDV1hVbDVCNGZqSC9qaGpNOVh5WEFzNThOeWNpYzZrNUxWem5rSDlN?= =?utf-8?B?Ty82UEN4MXJuVmY3cjRGWUFlR05TdlY2ZXQ3ZjQ3ZjVPdEtQOVJMUksrQkt2?= =?utf-8?B?SjRobmc0N3Y5NW1RN3FCWEQ1QkpLcmt0RmhDTDAxV21Ga3NvYitMN0cwV3V5?= =?utf-8?B?ZkVzZnBwL0EvTXp6UEM5ZG44Wk1xRFNRaGFWS1VyTzEwWGFoTUU5a09jdUNX?= =?utf-8?B?a2s4T1R6QTdOb0w0Zk1ZdzViVUdKM2JRS1FHRHRhclZITVJZNE0wQTRERWVy?= =?utf-8?B?cW51Z0NTblNiZHdaZVlwQktIcnJUMnJzYUxLNUZKSUd1MUZmQzNHOGJoQ2xI?= =?utf-8?B?ZkRBTytvSEZuOGc0N0E5eHZtTWJkRTdxT25sY0hMSVJ4bzRvYk14WW9QMGpQ?= =?utf-8?B?dnZRbXUrdTVJTWtvWWUxc2pRQm9aRkVWejBUZEZFMUM0RStMMVFOQUZLa3A1?= =?utf-8?B?YTlrenVUeStieGZsMm9kanZLRFJxNmlvaml6a2ZWWEFjUnpKVHVsRnYzeGUx?= =?utf-8?B?MmZMUWVONVNxYUhZTVE5MVlNM3VKSHJuUU9ETXFiY1hZU2owU1pqQ1Bnempp?= =?utf-8?B?VHZwa09lN1RlS2wwVys0dnFwTDNnc2FtS0wyZ21TWXZacnlzRjVQWk45SVda?= =?utf-8?B?bVRnZnVPOXMxTitsWnMwVFZDVHJNeS90aCs0ZjJCY29UUWc5QjM4dWZVM0Nx?= =?utf-8?B?eS9QckRiaFJBQ1pVeHhyMU12d0hqanZ4cCtIYk1OMGErajR6Q2dSdjhBZTRv?= =?utf-8?B?ZVZWZ3NZZVVtWXplcmZtVVB6VTlydklNdVZIYmNVRXhXVVpkVjRYWDRPRlR5?= =?utf-8?B?Qlo2ZjZxai8zRVhBMnRzRXlEN0pIUEpKdjBIK29SK0JtNmhrV0hxTzFFWHRR?= =?utf-8?B?VUNNN1k2U3d4aXhGNXpidnE2YmlWTmFDaGdXcHhYRFlwTExxSEJTTmJScWtr?= =?utf-8?B?NFI3R1Q4Mkh1Qm1kYTJwcm1XSGdaRlpoUXB3Unp1UFZYQ2Nqdm5Tc0E3b1lX?= =?utf-8?B?dmE1eFJhVHZXV3pFVEdwYmJKcUpvME1sWW1xZU5GNkt0a2swSmxEQmJJQy9s?= =?utf-8?B?MFFObkpxclpLcEJVd2I1NlN2a2FkdVFYd3VuZjhySm5Fa0hqZ2hBTm9ibXli?= =?utf-8?B?SGNGYzh5NWZQUlI4dWlRUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6179.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXNHSlZHaUJJYktYLzNScURLWUl0RDBScTBaNEpsOVNXZlVmeW5oWUdtbHNz?= =?utf-8?B?dStBbXhmZ2NDTlBHeDZiVmZPemlRcVlrd2ltL3VuTE85dDFraFVNWFRPWVpw?= =?utf-8?B?K3ZoaHZ1N0tIQXBtR0ZUR0V3RWtTdUZTOFJFam5oN05YcW16Q2Qvc2gwOXht?= =?utf-8?B?ZmNVbkE1TS9tTWR1bnQ5WkFLbW1iWURuOEg0VFdaZ2FvTGxRZmdhMzFxaVVK?= =?utf-8?B?QVlNaEtvY2xRakd0dWYwS0NzQ2luRWllRDlZZWxPTzFiOG81bHZBUXZZTkJa?= =?utf-8?B?SVBMUVJlQXRJd3JvSEZPb0hLa3NpMTJBUGpxMzh6ODVKSEtLZDZWbnZkSnNS?= =?utf-8?B?RDVNbFJ1OG9INTNRRklGZXA5Q2FtRFRnaTVsVlEwN0Z0dFZhS1lyZnR0bE5m?= =?utf-8?B?WFY5UzdSdUtTMmw1bG4rRWYxWi9ZMCtnMXVxR29wY0ZvTk9xeWFuMjRtRW1B?= =?utf-8?B?RVZWK3lBUXVZbGRIeG5GZGlMTU44dlc3MWF6c0M5a1NvVWhLdzI1czVTZmlx?= =?utf-8?B?bk5URUF6ZjVsTnJqMGJxaVFWK3BMelZtdUxjd1lQMVpWY0NiemFtZkRUdFFr?= =?utf-8?B?dUhtQlFDRkN0REgxS1k4cU9RL3F6K0hGOUNOYUpNQTN4a1RzSVByaVBMeVFH?= =?utf-8?B?NEc4SVYvTU5iN1U5czB1WHZUVk04SnFtSldENGRsTTY5TUh0RmdJOEdJQ0Vk?= =?utf-8?B?dGh0bkFMVElYQnBnMVRxUjVjYllLekdTbDdtaEhrZW1MZDlKOXlLTTd4ZHBa?= =?utf-8?B?cGcrQlE2N3JsclJCb3pGVHFKZ2crZnB3clpkbjZMakdUZ0ovMUJLbExDaW9z?= =?utf-8?B?eEZ6RVovd2d2RWd3dUZRbVg0MHRaN3ZRMGhZbTc1WjVqTjdtNXpjVnBOby9P?= =?utf-8?B?dTRzRWl4L1RNeTgvZVRnWi9UUndWdStsQUk2SUpZRFNESFdaN3RTdXdtdVNU?= =?utf-8?B?bldXQUhDVEdUS0lRTXA2Ni9XVDFWT25hdGFhVThQekpYRTdac05ieGlFbWZa?= =?utf-8?B?dnNRdGNsZEpIVWZyWjJnZlVHaU16dnJvVFJzT2FUV1dhbnpDOEhQSVVPd2li?= =?utf-8?B?aFgraER4Y1NrTEVPQnB6M3oxQU05bEZIeFZEMDV5SlY1Vm1pZzZmMnZ0aDNz?= =?utf-8?B?SHNwQnRrRVBZM2ZkNUl6L0I2Z2xRRHZ2aUVsOUJhMGFWZmRtL0lIVDFXeFFi?= =?utf-8?B?aHN5VmNJV0k0bldZOFJXUmhUWTQvVERpSERVb2ptWElIM09XenhqZVp1S3Nq?= =?utf-8?B?ODNUS1JpV2NGSG9hL2l0YzYzc0dlaU4vdCtMalhzUXlmUWdUS0JWUndUKytt?= =?utf-8?B?YnJqazlMaHBoems1bjNOTEk3U28rdVJNN3NReFlJcGJ3dUtZQnRiOW0yL3BL?= =?utf-8?B?ZmNjbmpsRWtuSmlOb0YrMWZZTXNIVFFMNDdsNWF5Y3pEanNQR1hjOEpVZXhQ?= =?utf-8?B?OUFEcjJpNWJiUyt0L0MrcXJPc1FORi9ZbEE2Y3ZTRlFpTVFGcWtPN05VRjU5?= =?utf-8?B?MEo5YS9WTVorL0VuWGpVbFU5d0JJQU5HM2lWVmU0TVBKMWN2VUdUL2FhSmZW?= =?utf-8?B?Z2FoclJMUGhOL2ErRGprTFZ3YUxVVXkyMEd3VnNqeHFTUmppNHZEbS9zNmx0?= =?utf-8?B?UVdIc1NBdFZ2aG9EMjlvNnZwK2oxaE14d1JxR3g1MlFsbG1ueWZ2dzBoc2RD?= =?utf-8?B?d1lDbklMeXBYRTBmcWdWdVhRdnpNWDltVTVSQnZuaVhwd09Bb1dLMDlnRGpu?= =?utf-8?B?eEtDN3VLdlc1TExrR3Y0M2tSV2psUUlkVEZRaGtSMjBISXp1TFZTSjIrZkJv?= =?utf-8?B?ZHNXVTVtVGdWMDZlTFFBZldPeFFPWUI0YUNsT285UURLVGV1Qk54SC9GSUNt?= =?utf-8?B?RUxzdjQ1K3BJczlER2VrZTd2Y0hZWFVvbmJ4Q1p5MXFZRlhaNlhVRm53Yjhv?= =?utf-8?B?N2x2ZlA5b0FWazlYZms3OFd3Vlorclk5eit2TWo2Tlk1eTdyYXhuNlo2UHQ0?= =?utf-8?B?YVVXbFcyajBBb3hrRHh0SDRlbXdReVRhNkRQU3pmejlWSU1OUmdxekhKZGox?= =?utf-8?B?WTIwUTA0OW5vTUd0M0NyMHo1aGo5dGZTWmFuemk0bnp4dG5vRHhDSjRXaHly?= =?utf-8?Q?E9iicmZtyDWzZLfK8vw4mMmq+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 985d04f0-970a-472e-7805-08dcb13d2c9a X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2024 08:45:47.9923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xDxG1+eiq7b+2myNFQHDyrgp+ooA6ea6aYdpt4bU5fkukCidFf6NVyF0CSprjPgniAUScScD1yujQM1bL8MOjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7471 On Tue, Jul 30, 2024 at 05:49:53PM -0700, Krzysztof Olędzki wrote: > Enable reading additional EEPROM information from high pages such as > thresholds and alarms on QSFP/QSFP+/QSFP28 modules. > > "This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add ^ Nit: s/^\"// > support for EEPROM high pages query") but given all the required logic > already exists in mlx4_qsfp_eeprom_params_set() only s/_LEN/MAX_LEN/ is > needed. > > Tested-by: Dan Merillat > Signed-off-by: Krzysztof Piotr Oledzki Reviewed-by: Ido Schimmel