Re: [PATCH v2 ethtool] qsfp: Better handling of Page 03h netlink read failure

[Ido Schimmel <idosch@nvidia.com>]

On Tue, Jul 30, 2024 at 05:49:33PM -0700, Krzysztof Olędzki wrote:
> When dumping the EEPROM contents of a QSFP transceiver module, ethtool
> will only ask the kernel to retrieve Upper Page 03h if the module
> advertised it as supported.
> 
> However, some kernel drivers like mlx4 are currently unable to provide
> the page, resulting in the kernel returning an error. Since Upper Page
> 03h is optional, do not treat the error as fatal. Instead, print an
> error message and allow ethtool to continue and parse / print the
> contents of the other pages.
> 
> Also, clarify potentially cryptic "netlink error: Invalid argument" message.
> 
> Before:
>  # ethtool -m eth3
>  netlink error: Invalid argument
> 
> After:
>  # ethtool -m eth3
>  netlink error: Invalid argument
>  Failed to read Upper Page 03h, driver error?
>          Identifier                                : 0x0d (QSFP+)
>          Extended identifier                       : 0x00
>  (...)
> 
> Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)")
> 

Nit: No blank line between Fixes and SoB, but maybe Michal can fix it up
when applying

> Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks!