From: Breno Leitao <leitao@debian.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
leit@meta.com, Chris Mason <clm@fb.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging
Date: Wed, 31 Jul 2024 04:24:39 -0700 [thread overview]
Message-ID: <Zqoe9/TiETNQmb7z@gmail.com> (raw)
In-Reply-To: <e6b1f967-aaf4-47f4-be33-c981a7abc120@redhat.com>
Hello Paolo,
On Tue, Jul 30, 2024 at 11:38:38AM +0200, Paolo Abeni wrote:
> Could you please benchmark such scenario before and after this patch?
I've tested it on a 18-core Xeon D-2191A host, and I haven't found any
different in either TX/RX in TCP or UDP. At the same time, I must admit
that I have very low confidence in my tests.
I run the following tests for 10x on the same machine, just changing my
patch, and I getting the simple average of these 10 iterations. This is
what I am doing for TCP and UDP:
TCP:
# iperf -s &
# iperf -u -c localhost
Output: 16.5 Gbits/sec
UDP:
# iperf -s -u &
# iperf -u -c localhost
Output: 1.05 Mbits/sec
I don't know how to explain why UDP numbers are so low. I am happy to
run different tests, if you have any other recommendation.
--breno
next prev parent reply other threads:[~2024-07-31 11:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 10:47 [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging Breno Leitao
2024-07-30 9:38 ` Paolo Abeni
2024-07-30 10:24 ` Breno Leitao
2024-07-30 10:50 ` Florian Westphal
2024-07-30 11:15 ` Paolo Abeni
2024-07-30 14:10 ` Jakub Kicinski
2024-07-30 14:21 ` Eric Dumazet
2024-07-30 14:37 ` Paolo Abeni
2024-07-30 14:48 ` Jakub Kicinski
2024-07-31 11:24 ` Breno Leitao [this message]
2024-07-31 11:53 ` Jason Xing
2024-08-01 9:07 ` Paolo Abeni
2024-08-01 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqoe9/TiETNQmb7z@gmail.com \
--to=leitao@debian.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).