From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
Shuah Khan <shuah@kernel.org>,
thevlad@fb.com, thepacketgeek@gmail.com, riel@surriel.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, paulmck@kernel.org,
davej@codemonkey.org.uk,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 1/6] net: netconsole: selftests: Create a new netconsole selftest
Date: Fri, 2 Aug 2024 01:09:00 -0700 [thread overview]
Message-ID: <ZqyUHN770pjSofTC@gmail.com> (raw)
In-Reply-To: <20240801095322.6d9dec9c@kernel.org>
Hello Jakub,
On Thu, Aug 01, 2024 at 09:53:22AM -0700, Jakub Kicinski wrote:
> On Thu, 1 Aug 2024 09:11:58 -0700 Breno Leitao wrote:
> > .../net/netconsole/basic_integration_test.sh | 153 ++++++++++++++++++
>
> It needs to be included in a Makefile
> If we only have one script I'd put it directly in .../net/,
> or drivers/netdevsim/? each target should technically have
> a Kconfig, Makefile, settings, no point for a single script.
Thanks for the feedback, I will wait a bit for more feedback, and then
send a v2 where I would move the script back to .../net.
--breno
next prev parent reply other threads:[~2024-08-02 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 16:11 [PATCH net-next 0/6] net: netconsole: Fix netconsole unsafe locking Breno Leitao
2024-08-01 16:11 ` [PATCH net-next 1/6] net: netconsole: selftests: Create a new netconsole selftest Breno Leitao
2024-08-01 16:53 ` Jakub Kicinski
2024-08-02 8:09 ` Breno Leitao [this message]
2024-08-01 16:11 ` [PATCH net-next 2/6] net: netpoll: extract core of netpoll_cleanup Breno Leitao
2024-08-01 16:12 ` [PATCH net-next 3/6] net: netconsole: Correct mismatched return types Breno Leitao
2024-08-01 16:12 ` [PATCH net-next 4/6] net: netconsole: Standardize variable naming Breno Leitao
2024-08-01 16:12 ` [PATCH net-next 5/6] net: netconsole: Unify Function Return Paths Breno Leitao
2024-08-01 16:12 ` [PATCH net-next 6/6] net: netconsole: Defer netpoll cleanup to avoid lock release during list traversal Breno Leitao
2024-08-01 16:21 ` Stephen Hemminger
2024-08-01 16:29 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqyUHN770pjSofTC@gmail.com \
--to=leitao@debian.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=riel@surriel.com \
--cc=shuah@kernel.org \
--cc=thepacketgeek@gmail.com \
--cc=thevlad@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).