Re: [PATCH net-next 01/12] selftests: drv-net: rss_ctx: add identifier to traffic comments

[Joe Damato <jdamato@fastly.com>]

On Thu, Aug 01, 2024 at 05:17:50PM -0700, Jakub Kicinski wrote:
> Include the "name" of the context in the comment for traffic
> checks. Makes it easier to reason about which context failed
> when we loop over 32 contexts (it may matter if we failed in
> first vs last, for example).
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  tools/testing/selftests/drivers/net/hw/rss_ctx.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
> index 011508ca604b..1da6b214f4fe 100755
> --- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py
> +++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
> @@ -90,10 +90,10 @@ from lib.py import ethtool, ip, defer, GenerateTraffic, CmdExitFailure
>      ksft_ge(directed, 20000, f"traffic on {name}: " + str(cnts))
>      if params.get('noise'):
>          ksft_lt(sum(cnts[i] for i in params['noise']), directed / 2,
> -                "traffic on other queues:" + str(cnts))
> +                f"traffic on other queues ({name})':" + str(cnts))
>      if params.get('empty'):
>          ksft_eq(sum(cnts[i] for i in params['empty']), 0,
> -                "traffic on inactive queues: " + str(cnts))
> +                f"traffic on inactive queues ({name}): " + str(cnts))
>  
>  
>  def test_rss_key_indir(cfg):

Reviewed-by: Joe Damato <jdamato@fastly.com>