From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACC271E2124 for ; Fri, 2 Aug 2024 11:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722598073; cv=none; b=B3ONSEHUPbhS0qi9jBVdGYMgs9Uod87hn57EpyKqbZEjJ+ulwiz1NHDQ3nsdVbT+a1/qIlSKgM3Ndxpld8Iq02hI0xOI/3H99GoU6m0QH348a5UjdfI6FxxPIvNNKGq4r3HCZ2gw0WKv7BZzdC4YaejmWacD4XvkGJJc7e7uMpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722598073; c=relaxed/simple; bh=BE7dpG8W2PpOKUlssqTXhlePO4gl/CQaWw0AeimD9y4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M1TcWTEKsrPnGnwX+NFyK0Uy7DhN9P+2nXAjIS1TTMLxptvVVx1/8OO0D8N8YZtEIs4dRs1TImXw7UKoVxgtOGMfSbk4nPxx1Ep6H8sZd9RGPaKgpn9fjvFxV9aPhDG+J8ABmXxmUKxJB758hvMyYGrDuz+GK8w0B/0XONYXfcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=kTWl68we; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="kTWl68we" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-428e1915e18so11822905e9.1 for ; Fri, 02 Aug 2024 04:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1722598070; x=1723202870; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=chN/5IqC5/jQjFOqjkhbCXjZQHoVidazye4I/EM8vkk=; b=kTWl68wedmlpbnpxUW1ltHUuJHXQftgtls2Smo05lXtV3V9+3ayUXxSW9RM+b4GouV PHJ3vc85V6PH8/jND8E535KkIzSXtY1qPUahm4bNZ14uBCZrPBH66XAM9ZPiOBbpAyjh WGcdxFV7GuZu6KMawkBSmtkE8jg2FwScsSGfY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722598070; x=1723202870; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=chN/5IqC5/jQjFOqjkhbCXjZQHoVidazye4I/EM8vkk=; b=k3VHkIYxBpOdICiyKOnw3RipE4sAA4KDyS+Lzwe0cFUhsNfTkLz3Yl5bc8WeJ43BH8 b4juTEl0wwsMokieYMdQlgTCSLML82lHcfAdhKyj8WBnfPYQvkkD11VKvESRyPzN/z2Q Of22r5osqC6RwvD2claSkgx8iJtmqSjA3ibh/XtWXiTAgI+WyPzajilRQNGnEn1c0MYW kGxVSo7umddg1sQ35T2RZgamksmZNQWUIkcntisscbzuo3I+CxSsJe0sznRKMr7AArG5 rlpHhVc3q0wYA2hRtP15vbsLau5+48pnR/CjMK9FNoNNGyGfblfSTwQ4pnx8xDiCT75D 1PFA== X-Forwarded-Encrypted: i=1; AJvYcCXN0AjiRDCRZ+HHiixV3n3Smqye0ptV/nkbyUBdkZ5kpPpwSOQh2V+2O1tfL6hYgSCXbpNDaQTZko0yD0I3hRobqeaCKXvQ X-Gm-Message-State: AOJu0Yyxh0AEopPj9/JvHL2qVumNYqMXYKW8EyTcDFJ9YHZ6fn3xWKxK wavq73KekQ0XJbvzRLU5l4I2Iw5CX0lZYMCoKUJaE3Sih227FFsttpZRZwORbWI= X-Google-Smtp-Source: AGHT+IH7hcdVBDXCsRevDN59P0EtrOCoyykAhwY0K0NGMZXYks/7iPTFXtJU/BBOxs8N4RGobZG6mA== X-Received: by 2002:a05:600c:5102:b0:428:52a:3580 with SMTP id 5b1f17b1804b1-428e6af4b58mr18796515e9.3.1722598069823; Fri, 02 Aug 2024 04:27:49 -0700 (PDT) Received: from LQ3V64L9R2 ([62.30.8.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e6e3c0b7sm29576275e9.23.2024.08.02.04.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 04:27:49 -0700 (PDT) Date: Fri, 2 Aug 2024 12:27:46 +0100 From: Joe Damato To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, dxu@dxuuu.xyz, ecree.xilinx@gmail.com, przemyslaw.kitszel@intel.com, donald.hunter@gmail.com, gal.pressman@linux.dev, tariqt@nvidia.com, willemdebruijn.kernel@gmail.com, saeedm@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next 03/12] eth: mlx5: allow disabling queues when RSS contexts exist Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, dxu@dxuuu.xyz, ecree.xilinx@gmail.com, przemyslaw.kitszel@intel.com, donald.hunter@gmail.com, gal.pressman@linux.dev, tariqt@nvidia.com, willemdebruijn.kernel@gmail.com, saeedm@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org References: <20240802001801.565176-1-kuba@kernel.org> <20240802001801.565176-4-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802001801.565176-4-kuba@kernel.org> On Thu, Aug 01, 2024 at 05:17:52PM -0700, Jakub Kicinski wrote: > Since commit 24ac7e544081 ("ethtool: use the rss context XArray > in ring deactivation safety-check") core will prevent queues from > being disabled while being used by additional RSS contexts. > The safety check is no longer necessary, and core will do a more > accurate job of only rejecting changes which can actually break > things. > > Signed-off-by: Jakub Kicinski > --- > CC: saeedm@nvidia.com > CC: tariqt@nvidia.com > CC: leon@kernel.org > CC: linux-rdma@vger.kernel.org > --- > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > index 36845872ae94..0b941482db30 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > @@ -445,7 +445,6 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv, > unsigned int count = ch->combined_count; > struct mlx5e_params new_params; > bool arfs_enabled; > - int rss_cnt; > bool opened; > int err = 0; > > @@ -499,17 +498,6 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv, > goto out; > } > > - /* Don't allow changing the number of channels if non-default RSS contexts exist, > - * the kernel doesn't protect against set_channels operations that break them. > - */ > - rss_cnt = mlx5e_rx_res_rss_cnt(priv->rx_res) - 1; > - if (rss_cnt) { > - err = -EINVAL; > - netdev_err(priv->netdev, "%s: Non-default RSS contexts exist (%d), cannot change the number of channels\n", > - __func__, rss_cnt); > - goto out; > - } > - > /* Don't allow changing the number of channels if MQPRIO mode channel offload is active, > * because it defines a partition over the channels queues. > */ > -- > 2.45.2 Reviewed-by: Joe Damato