netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Maciek Machnikowski <maciek@machnikowski.net>,
	netdev@vger.kernel.org, jacob.e.keller@intel.com,
	darinzon@amazon.com, kuba@kernel.org
Subject: Re: [RFC 0/3] ptp: Add esterror support
Date: Thu, 15 Aug 2024 07:24:10 +0200	[thread overview]
Message-ID: <Zr2Q-sti4TjSjEug@localhost> (raw)
In-Reply-To: <Zr2BDLnmIHCrceze@hoboy.vegasvil.org>

On Wed, Aug 14, 2024 at 09:16:12PM -0700, Richard Cochran wrote:
> Actually, looking at the NTP code, we have:
> 
> void process_adjtimex_modes(const struct __kernel_timex *txc,)
> {
> 	...
> 	if (txc->modes & ADJ_ESTERROR)
> 		time_esterror = txc->esterror;
> 	...
> }
> 
> So I guess PHCs should also support setting this from user space?

Yes, I'd like that very much. It would allow other applications to get
the estimated error of the clock they are using. Maxerror would be
nice too, even if it didn't increase automatically at 500 ppm as the
system clock. IIRC this was proposed before for the cross-timestamping
PHC between VM host and guests, but there wasn't much interest at the
time.

-- 
Miroslav Lichvar


  reply	other threads:[~2024-08-15  5:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 12:55 [RFC 0/3] ptp: Add esterror support Maciek Machnikowski
2024-08-13 12:56 ` [RFC 1/3] ptp: Implement timex " Maciek Machnikowski
2024-08-14  9:29   ` Vadim Fedorenko
2024-08-15  9:33     ` Maciek Machnikowski
2024-08-14 11:46   ` Simon Horman
2024-08-15  9:32     ` Maciek Machnikowski
2024-08-15  4:23   ` Richard Cochran
2024-08-15  9:43     ` Maciek Machnikowski
2024-08-15  9:47     ` Maciek Machnikowski
2024-08-15 21:04       ` Richard Cochran
2024-08-13 12:56 ` [RFC 2/3] ptp: Implement support for esterror in ptp_mock Maciek Machnikowski
2024-08-13 12:56 ` [RFC 3/3] ptp: Add setting esterror and reading timex structure Maciek Machnikowski
2024-08-13 20:05 ` [RFC 0/3] ptp: Add esterror support Andrew Lunn
2024-08-14  8:44   ` Vadim Fedorenko
2024-08-14 13:08     ` Andrew Lunn
2024-08-14 15:08       ` Maciek Machnikowski
2024-08-15  3:53         ` Richard Cochran
2024-08-15  9:40           ` Maciek Machnikowski
2024-08-15 14:26             ` Andrew Lunn
2024-08-15 15:00               ` Maciek Machnikowski
2024-08-15 21:08                 ` Richard Cochran
2024-08-15 22:06                   ` Maciek Machnikowski
2024-08-15 23:11                     ` Andrew Lunn
2024-08-16  4:13                       ` Maciek Machnikowski
2024-08-17  4:29                     ` Richard Cochran
2024-08-15  3:33       ` Richard Cochran
2024-08-15  4:16         ` Richard Cochran
2024-08-15  5:24           ` Miroslav Lichvar [this message]
2024-08-15  9:45             ` Maciek Machnikowski
2024-08-15  9:41           ` Maciek Machnikowski
2024-08-15  0:41 ` Jakub Kicinski
2024-08-15  3:42   ` Richard Cochran
2024-08-15  4:17     ` Richard Cochran
2024-08-15  9:35   ` Maciek Machnikowski
2024-08-15 10:29     ` Vadim Fedorenko
2024-08-15 11:40       ` Arinzon, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr2Q-sti4TjSjEug@localhost \
    --to=mlichvar@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=darinzon@amazon.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=maciek@machnikowski.net \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).