From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Tariq Toukan <tariqt@nvidia.com>, Jianbo Liu <jianbol@nvidia.com>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net-next 0/2] Bonding: support new xfrm state offload functions
Date: Fri, 16 Aug 2024 16:35:29 +0800 [thread overview]
Message-ID: <Zr8PUTUWY3rh15Ik@Laptop-X1> (raw)
In-Reply-To: <ab09bdf3-e67b-4548-87a9-acf9a08806c6@blackwall.org>
On Fri, Aug 16, 2024 at 09:00:17AM +0300, Nikolay Aleksandrov wrote:
> the set looks good to me, one minor cosmetic nit is that the two
> functions look very much alike only difference is the actual call
> can you maybe factor out the boilerplate?
Thanks, I will update the patch to use a common function for the checking.
Hangbin
next prev parent reply other threads:[~2024-08-16 8:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 3:55 [PATCH net-next 0/2] Bonding: support new xfrm state offload functions Hangbin Liu
2024-08-16 3:55 ` [PATCH net-next 1/2] bonding: Add ESN support to IPSec HW offload Hangbin Liu
2024-08-16 16:32 ` Simon Horman
2024-08-17 11:36 ` kernel test robot
2024-08-16 3:55 ` [PATCH net-next 2/2] bonding: support xfrm state update Hangbin Liu
2024-08-16 4:01 ` [PATCH net-next 0/2] Bonding: support new xfrm state offload functions Hangbin Liu
2024-08-16 6:00 ` Nikolay Aleksandrov
2024-08-16 8:35 ` Hangbin Liu [this message]
2024-08-16 6:06 ` Nikolay Aleksandrov
2024-08-16 8:32 ` Hangbin Liu
2024-08-16 8:37 ` Nikolay Aleksandrov
2024-08-16 9:04 ` Nikolay Aleksandrov
2024-08-16 9:58 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr8PUTUWY3rh15Ik@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jianbol@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sd@queasysnail.net \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).