netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Geliang Tang <geliang@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>,
	Hangbin Liu <liuhangbin@gmail.com>,
	Benjamin Poirier <bpoirier@nvidia.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Geliang Tang <tanggeliang@kylinos.cn>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: forwarding: lib.sh: ignore "Address not found"
Date: Tue, 6 Aug 2024 10:40:25 +0300	[thread overview]
Message-ID: <ZrHTafNilRs6dx6E@shredder.mtl.com> (raw)
In-Reply-To: <764585b6852537a93c6fba3260e311b79280267a.1722917654.git.tanggeliang@kylinos.cn>

On Tue, Aug 06, 2024 at 12:20:38PM +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> So many "Address not found" messages occur at the end of forwarding tests
> when using "ip address del" command for an invalid address:

Can you give an example of an invalid address that triggers this
message?

> 
> TEST: FDB limits interacting with FDB type local                    [ OK ]
> Error: ipv4: Address not found.
> 
> ... ...
> TEST: IGMPv3 S,G port entry automatic add to a *,G port             [ OK ]
> Error: ipv4: Address not found.
> Error: ipv6: address not found.
> 
> ... ...
> TEST: Isolated port flooding                                        [ OK ]
> Error: ipv4: Address not found.
> Error: ipv6: address not found.
> 
> ... ...
> TEST: Externally learned FDB entry - ageing & roaming               [ OK ]
> Error: ipv4: Address not found.
> Error: ipv6: address not found.

I'm unable to reproduce these with net-next and iproute2-next. Please
debug this to understand the root cause or provide more details on how
to reproduce.

> 
> This patch gnores these messages and redirects them to /dev/null in
> __addr_add_del().
> 
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index ff96bb7535ff..8670b6053cde 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -839,7 +839,7 @@ __addr_add_del()
>  	array=("${@}")
>  
>  	for addrstr in "${array[@]}"; do
> -		ip address $add_del $addrstr dev $if_name
> +		ip address $add_del $addrstr dev $if_name &> /dev/null
>  	done
>  }
>  
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2024-08-06  7:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06  4:20 [PATCH net-next] selftests: forwarding: lib.sh: ignore "Address not found" Geliang Tang
2024-08-06  7:34 ` Nicolas Dichtel
2024-08-07  4:12   ` Geliang Tang
2024-08-06  7:40 ` Ido Schimmel [this message]
2024-08-07  4:08   ` Geliang Tang
2024-08-07  6:59     ` Ido Schimmel
2024-08-08  8:53       ` Geliang Tang
2024-08-08 14:25         ` Ido Schimmel
2024-08-07 14:32     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrHTafNilRs6dx6E@shredder.mtl.com \
    --to=idosch@nvidia.com \
    --cc=bpoirier@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geliang@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=tanggeliang@kylinos.cn \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).