Netdev List
 help / color / mirror / Atom feed
From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, michael.chan@broadcom.com, shuah@kernel.org,
	ecree.xilinx@gmail.com, przemyslaw.kitszel@intel.com,
	ahmed.zaki@intel.com, andrew@lunn.ch, willemb@google.com,
	pavan.chebbi@broadcom.com, petrm@nvidia.com, gal@nvidia.com,
	donald.hunter@gmail.com
Subject: Re: [PATCH net-next v3 11/12] netlink: specs: decode indirection table as u32 array
Date: Wed, 7 Aug 2024 13:00:22 +0100	[thread overview]
Message-ID: <ZrNh1lNwKAzEwTHw@LQ3V64L9R2> (raw)
In-Reply-To: <20240806193317.1491822-12-kuba@kernel.org>

On Tue, Aug 06, 2024 at 12:33:16PM -0700, Jakub Kicinski wrote:
> Indirection table is dumped as a raw u32 array, decode it.
> It's tempting to decode hash key, too, but it is an actual
> bitstream, so leave it be for now.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  Documentation/netlink/specs/ethtool.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 4c2334c213b0..1bbeaba5c644 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -1022,6 +1022,7 @@ doc: Partial family for Ethtool Netlink.
>        -
>          name: indir
>          type: binary
> +        sub-type: u32
>        -
>          name: hkey
>          type: binary
> -- 
> 2.45.2
> 

Reviewed-by: Joe Damato <jdamato@fastly.com>

  reply	other threads:[~2024-08-07 12:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 19:33 [PATCH net-next v3 00/12] ethtool: rss: driver tweaks and netlink context dumps Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 01/12] selftests: drv-net: rss_ctx: add identifier to traffic comments Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 02/12] eth: mvpp2: implement new RSS context API Jakub Kicinski
2024-08-08 11:22   ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 03/12] eth: mlx5: allow disabling queues when RSS contexts exist Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 04/12] ethtool: make ethtool_ops::cap_rss_ctx_supported optional Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 05/12] eth: remove .cap_rss_ctx_supported from updated drivers Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 06/12] ethtool: rss: don't report key if device doesn't support it Jakub Kicinski
2024-08-08 11:26   ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 07/12] ethtool: rss: move the device op invocation out of rss_prepare_data() Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 08/12] ethtool: rss: report info about additional contexts from XArray Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 09/12] ethtool: rss: support dumping RSS contexts Jakub Kicinski
2024-08-08 11:33   ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 10/12] ethtool: rss: support skipping contexts during dump Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 11/12] netlink: specs: decode indirection table as u32 array Jakub Kicinski
2024-08-07 12:00   ` Joe Damato [this message]
2024-08-06 19:33 ` [PATCH net-next v3 12/12] selftests: drv-net: rss_ctx: test dumping RSS contexts Jakub Kicinski
2024-08-08 10:05   ` Petr Machata
2024-08-08 11:42   ` Edward Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrNh1lNwKAzEwTHw@LQ3V64L9R2 \
    --to=jdamato@fastly.com \
    --cc=ahmed.zaki@intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=petrm@nvidia.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox