Re: [PATCH net-next 2/2] eth: fbnic: add support for basic qstats

Joe Damato
2024-08-07T15:45:10Z

On Tue, Aug 06, 2024 at 07:26:31PM -0700, Jakub Kicinski wrote:
> From: Stanislav Fomichev <sdf@fomichev.me>
>
> Implement netdev_stat_ops and export the basic per-queue stats.
>
> This interface expect users to set the values that are used
> either to zero or to some other preserved value (they are 0xff by
> default). So here we export bytes/packets/drops from tx and rx_stats
> plus set some of the values that are exposed by queue stats
> to zero.
>
> $ cd tools/testing/selftests/drivers/net && ./stats.py
> [...]
> Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> .../net/ethernet/meta/fbnic/fbnic_netdev.c | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)

Reviewed-by: Joe Damato <jdamato@fastly.com>