From: Cong Wang <xiyou.wangcong@gmail.com>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org,
tparkin@katalix.com,
syzbot+6acef9e0a4d1f46c83d4@syzkaller.appspotmail.com,
gnault@redhat.com, cong.wang@bytedance.com
Subject: Re: [PATCH net] l2tp: fix lockdep splat
Date: Sun, 11 Aug 2024 10:57:22 -0700 [thread overview]
Message-ID: <Zrj7ggOFooYu0hHE@pop-os.localdomain> (raw)
In-Reply-To: <20240806160626.1248317-1-jchapman@katalix.com>
On Tue, Aug 06, 2024 at 05:06:26PM +0100, James Chapman wrote:
> diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
> index c80ab3f26084..2e86f520f799 100644
> --- a/net/l2tp/l2tp_core.c
> +++ b/net/l2tp/l2tp_core.c
> @@ -86,6 +86,11 @@
> /* Default trace flags */
> #define L2TP_DEFAULT_DEBUG_FLAGS 0
>
> +#define L2TP_DEPTH_NESTING 2
> +#if L2TP_DEPTH_NESTING == SINGLE_DEPTH_NESTING
> +#error "L2TP requires its own lockdep subclass"
> +#endif
This looks a bit over-engineering.
Why not just #define L2TP_DEPTH_NESTING SINGLE_DEPTH_NESTING+1?
Thanks.
prev parent reply other threads:[~2024-08-11 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 16:06 [PATCH net] l2tp: fix lockdep splat James Chapman
2024-08-08 16:20 ` patchwork-bot+netdevbpf
2024-08-11 17:57 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrj7ggOFooYu0hHE@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+6acef9e0a4d1f46c83d4@syzkaller.appspotmail.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox