Re: [PATCH net-next v3 2/2] gve: Add RSS adminq commands and ethtool support

[Hariprasad Kelam <hkelam@marvell.com>]

On 2024-08-13 at 03:50:13, Praveen Kaligineedi (pkaligineedi@google.com) wrote:
> From: Jeroen de Borst <jeroendb@google.com>
> 
> Introduce adminq commands to configure and retrieve RSS settings from
> the device. Implement corresponding ethtool ops for user-level
> management.
> 
> Signed-off-by: Jeroen de Borst <jeroendb@google.com>
> Co-developed-by: Ziwei Xiao <ziweixiao@google.com>
> Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> ---
> Changes in v2:
> 	- Update the GVE's get/set_rxfh functions to send the
> 	  ethtool_rxfh_param directly to related adminq functions so
> 	  that it can avoid the extra copy between ethtool and the
> 	  local gve_rss_config struct(Jakub Kicinski)
> 	- Remove the struct gve_rss_config that becomes unused
> 	- Add a comment in the gve_adminq_configure_rss function to
> 	  describe the device expections for the configure_rss adminq
> 	  command
> 
>  drivers/net/ethernet/google/gve/gve.h         |   2 +
>  drivers/net/ethernet/google/gve/gve_adminq.c  | 146 ++++++++++++++++++
>  drivers/net/ethernet/google/gve/gve_adminq.h  |  44 ++++++
>  drivers/net/ethernet/google/gve/gve_ethtool.c |  44 +++++-
>  4 files changed, 235 insertions(+), 1 deletion(-)
>
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>