From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API
Date: Mon, 19 Aug 2024 18:10:32 -0700 [thread overview]
Message-ID: <ZsPtCPwnXAyHG2Jq@google.com> (raw)
The driver does not not use gpiod API calls in an atomic context. Switch
to gpiod_set_value_cansleep() calls to allow using the driver with GPIO
controllers that might need process context to operate.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/nfc/st95hf/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
index ffe5b4eab457..5b3451fc4491 100644
--- a/drivers/nfc/st95hf/core.c
+++ b/drivers/nfc/st95hf/core.c
@@ -450,19 +450,19 @@ static int st95hf_select_protocol(struct st95hf_context *stcontext, int type)
static void st95hf_send_st95enable_negativepulse(struct st95hf_context *st95con)
{
/* First make irq_in pin high */
- gpiod_set_value(st95con->enable_gpiod, HIGH);
+ gpiod_set_value_cansleep(st95con->enable_gpiod, HIGH);
/* wait for 1 milisecond */
usleep_range(1000, 2000);
/* Make irq_in pin low */
- gpiod_set_value(st95con->enable_gpiod, LOW);
+ gpiod_set_value_cansleep(st95con->enable_gpiod, LOW);
/* wait for minimum interrupt pulse to make st95 active */
usleep_range(1000, 2000);
/* At end make it high */
- gpiod_set_value(st95con->enable_gpiod, HIGH);
+ gpiod_set_value_cansleep(st95con->enable_gpiod, HIGH);
}
/*
--
2.46.0.184.g6999bdac58-goog
--
Dmitry
next reply other threads:[~2024-08-20 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 1:10 Dmitry Torokhov [this message]
2024-08-20 8:10 ` [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API Przemek Kitszel
2024-08-20 13:53 ` Andrew Lunn
2024-08-20 16:38 ` Dmitry Torokhov
2024-08-20 15:26 ` Jakub Kicinski
2024-08-20 16:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsPtCPwnXAyHG2Jq@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).