From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API
Date: Tue, 20 Aug 2024 09:37:15 -0700 [thread overview]
Message-ID: <ZsTGO46wSsIuMQdf@google.com> (raw)
In-Reply-To: <20240820082614.0e9e9192@kernel.org>
On Tue, Aug 20, 2024 at 08:26:14AM -0700, Jakub Kicinski wrote:
> On Mon, 19 Aug 2024 18:10:32 -0700 Dmitry Torokhov wrote:
> > The driver does not not use gpiod API calls in an atomic context. Switch
> > to gpiod_set_value_cansleep() calls to allow using the driver with GPIO
> > controllers that might need process context to operate.
>
> Could you explain why? Are you using this device? Is it part of some
> larger effort to remove an API?
Because it is better to use sleeping variants of gpiod API unless the
call is in atomic context, so it is basic code hygiene. We do not want
other drivers to copy the behavior.
I was going through my WIP patches and decided to sent it out. Originally
it was part of overall transition of the driver to gpiod API, but Andy
Shevchenko beat me to it, so movement to gpiod_set_value_cansleep()
is all that is left.
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-08-20 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 1:10 [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API Dmitry Torokhov
2024-08-20 8:10 ` Przemek Kitszel
2024-08-20 13:53 ` Andrew Lunn
2024-08-20 16:38 ` Dmitry Torokhov
2024-08-20 15:26 ` Jakub Kicinski
2024-08-20 16:37 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsTGO46wSsIuMQdf@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).