From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Philipp Stanner <pstanner@redhat.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Jens Axboe" <axboe@kernel.dk>, "Wu Hao" <hao.wu@intel.com>,
"Tom Rix" <trix@redhat.com>, "Moritz Fischer" <mdf@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Alvaro Karsz" <alvaro.karsz@solid-run.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Hannes Reinecke" <hare@suse.de>,
"Keith Busch" <kbusch@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-fpga@vger.kernel.org,
linux-gpio@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
virtualization@lists.linux.dev
Subject: Re: [PATCH v2 6/9] ethernet: stmicro: Simplify PCI devres usage
Date: Wed, 21 Aug 2024 14:55:38 +0300 [thread overview]
Message-ID: <ZsXVuq2jthHoTHPO@smile.fi.intel.com> (raw)
In-Reply-To: <be1c2f6fb63542ccdcb599956145575293625c37.camel@redhat.com>
On Wed, Aug 21, 2024 at 11:36:36AM +0200, Philipp Stanner wrote:
> On Wed, 2024-08-21 at 11:14 +0300, Andy Shevchenko wrote:
> > On Wed, Aug 21, 2024 at 10:19 AM Philipp Stanner
> > <pstanner@redhat.com> wrote:
...
> > > - for (i = 0; i < PCI_STD_NUM_BARS; i++) {
> > > - if (pci_resource_len(pdev, i) == 0)
> > > - continue;
> > > - pcim_iounmap_regions(pdev, BIT(i));
> >
> > Here is the BARx, which contradicts the probe :-)
>
> I'm not sure what should be done about it. The only interesting
> question is whether the other code with pcim_iomap_regions(... BIT(i)
> does also only grap BAR 0.
> In that case the driver wouldn't even be knowing what its own hardware
> is / does, though.
I think your patch does the right thing already.
> > > - break;
> > > - }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-21 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:18 [PATCH v2 0/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-21 7:18 ` [PATCH v2 1/9] PCI: Make pcim_iounmap_region() a public function Philipp Stanner
2024-08-21 7:18 ` [PATCH v2 2/9] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-08-21 8:22 ` Andy Shevchenko
2024-08-21 7:18 ` [PATCH v2 3/9] block: mtip32xx: " Philipp Stanner
2024-08-21 8:20 ` Andy Shevchenko
2024-08-21 7:18 ` [PATCH v2 4/9] gpio: " Philipp Stanner
2024-08-21 7:18 ` [PATCH v2 5/9] ethernet: cavium: " Philipp Stanner
2024-08-21 7:18 ` [PATCH v2 6/9] ethernet: stmicro: Simplify PCI devres usage Philipp Stanner
2024-08-21 8:14 ` Andy Shevchenko
2024-08-21 9:36 ` Philipp Stanner
2024-08-21 11:55 ` Andy Shevchenko [this message]
2024-08-21 7:18 ` [PATCH v2 7/9] vdpa: solidrun: Fix potential UB bug with devres Philipp Stanner
2024-08-21 10:00 ` Christophe JAILLET
2024-08-21 12:12 ` Michael S. Tsirkin
2024-08-21 12:25 ` Philipp Stanner
2024-08-21 7:18 ` [PATCH v2 8/9] vdap: solidrun: Replace deprecated PCI functions Philipp Stanner
2024-08-21 8:19 ` Andy Shevchenko
2024-08-21 7:18 ` [PATCH v2 9/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsXVuq2jthHoTHPO@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dlechner@baylibre.com \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hao.wu@intel.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=joabreu@synopsys.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mdf@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pstanner@redhat.com \
--cc=richardcochran@gmail.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).