netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Robert Marko <robimarko@gmail.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Chad Monroe <chad.monroe@adtran.com>,
	John Crispin <john@phrozen.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: aquantia: allow forcing order of MDI pairs
Date: Wed, 21 Aug 2024 17:18:44 +0100	[thread overview]
Message-ID: <ZsYTZK4Ku2LoZ4SA@makrotopia.org> (raw)
In-Reply-To: <a59be297-1a55-4cce-a3e1-7568e3d4e66c@lunn.ch>

On Wed, Aug 21, 2024 at 06:07:06PM +0200, Andrew Lunn wrote:
> On Wed, Aug 21, 2024 at 01:46:50PM +0100, Daniel Golle wrote:
> > Normally, the MDI reversal configuration is taken from the MDI_CFG pin.
> > However, some hardware designs require overriding the value configured
> > by that bootstrap pin. The PHY allows doing that by setting a bit which
> > allows ignoring the state of the MDI_CFG pin and configuring whether
> > the order of MDI pairs should be normal (ABCD) or reverse (DCBA).
> > 
> > Introduce two boolean properties which allow forcing either normal or
> > reverse order of the MDI pairs from DT.
> 
> How does this interact with ethtool -s eth42 [mdix auto|on|off]
> 
> In general, you want mdix auto, so the two ends figure out how the
> cable is wired and so it just works.

It looks like Aquantia only supports swapping pair (1,2) with pair (3,6)
like it used to be for MDI-X on 100MBit/s networks.

When all 4 pairs are in use (for 1000MBit/s or faster) the link does not
come up with pair order is not configured correctly, either using MDI_CFG
pin or using the "PMA Receive Reserved Vendor Provisioning 1" register.

And yes, I did verify that Auto MDI-X is enabled in the
"Autonegotiation Reserved Vendor Provisioning 1" register.

  reply	other threads:[~2024-08-21 16:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 12:46 [PATCH net-next 1/2] dt-bindings: net: marvell,aquantia: add properties to override MDI_CFG Daniel Golle
2024-08-21 12:46 ` [PATCH net-next 2/2] net: phy: aquantia: allow forcing order of MDI pairs Daniel Golle
2024-08-21 16:07   ` Andrew Lunn
2024-08-21 16:18     ` Daniel Golle [this message]
2024-08-23  1:28       ` Andrew Lunn
2024-08-27 15:15         ` Daniel Golle
2024-08-22  6:51   ` kernel test robot
2024-08-22  7:54   ` kernel test robot
2024-08-22  8:04   ` kernel test robot
2024-08-21 15:51 ` [PATCH net-next 1/2] dt-bindings: net: marvell,aquantia: add properties to override MDI_CFG Conor Dooley
2024-08-21 16:00 ` Andrew Lunn
2024-08-21 16:08   ` Daniel Golle
2024-08-21 16:13     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsYTZK4Ku2LoZ4SA@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=chad.monroe@adtran.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=john@phrozen.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).