From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E56F1CC151; Thu, 22 Aug 2024 14:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724337941; cv=none; b=R9VFt2MGiChisaiY8Gw9RynC3N0/5fDDZcrcQXF/xe39nXMe3JHKAs8rTIcT1hLl19La+fVZ9g2pCe12x8bgG0umHWXtT3UaKMptcN65XJBcJMmO9XSYbgx6EK41G33qH6p+0IUr0aEU+TYBTFoMfylmQh5X/w0iw/cRZTspSgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724337941; c=relaxed/simple; bh=UcNmewGgwyuxbDnzR4bXFjP2OTNp1avsMTCp4oLUCHs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s6P8uegCJWodsxGKWZTL8RBj3xqumRmQZOZ+2HYfj4NjcKD3+iIiV40HotOXc0s7PVE4ewSf9AvPzsvncce2bXln+Q7F72riiCBkPmF21TbkuAKa/kC3mGp1H3G8kDq1UlKoEkWGNqMvlgR9nz2tTJSihGyEhJtsliK3M5Ud9+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: JYs8hsk/SPOqOm6KgRIllA== X-CSE-MsgGUID: oOlud7wuS9+NH2oiiWXqUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="22360667" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="22360667" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:45:38 -0700 X-CSE-ConnectionGUID: 8qTJ1xUcTSCwD9dSqx9njw== X-CSE-MsgGUID: DQf8vM2PTiWk6u+9lqITwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="65665426" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:45:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh93K-00000000U3f-1bWg; Thu, 22 Aug 2024 17:44:42 +0300 Date: Thu, 22 Aug 2024 17:44:42 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: Jonathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH v3 5/9] ethernet: cavium: Replace deprecated PCI functions Message-ID: References: <20240822134744.44919-1-pstanner@redhat.com> <20240822134744.44919-6-pstanner@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822134744.44919-6-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Aug 22, 2024 at 03:47:37PM +0200, Philipp Stanner wrote: > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by > the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > Replace these functions with the function pcim_iomap_region(). ... > - err = pcim_iomap_regions(pdev, 1 << PCI_PTP_BAR_NO, pci_name(pdev)); > - if (err) > + clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); > + if (IS_ERR(clock->reg_base)) { > + err = PTR_ERR(clock->reg_base); > goto error_free; > - > - clock->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO]; > + } Perhaps clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); err = PTR_ERR_OR_ZERO(clock->reg_base); if (err) goto error_free; This will make your patch smaller and neater. P.S. Do you use --histogram diff algo when preparing patches? -- With Best Regards, Andy Shevchenko