netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: andi.shyti@kernel.org, jarkko.nikula@linux.intel.com,
	mika.westerberg@linux.intel.com, jsd@semihalf.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, rmk+kernel@armlinux.org.uk,
	piotr.raczynski@intel.com, andrew@lunn.ch,
	linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
	mengyuanlou@net-swift.com, duanqiangwen@net-swift.com,
	stable@vger.kernel.org
Subject: Re: [PATCH net 2/3] i2c: designware: add device private data passing to lock functions
Date: Fri, 23 Aug 2024 17:06:56 +0300	[thread overview]
Message-ID: <ZsiXgHDZi8DpgOWs@smile.fi.intel.com> (raw)
In-Reply-To: <20240823030242.3083528-3-jiawenwu@trustnetic.com>

On Fri, Aug 23, 2024 at 11:02:41AM +0800, Jiawen Wu wrote:
> In order to add the hardware lock for Wangxun devices with minimal
> modification, pass struct dw_i2c_dev to the acquire and release lock
> functions.

...

> +static int iosf_mbi_block_punit_i2c_access_dev(struct dw_i2c_dev *dev)

> +static void iosf_mbi_unblock_punit_i2c_access_dev(struct dw_i2c_dev *dev)

Rather name them in accordance with the namespace of this module.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-08-23 14:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23  3:02 [PATCH net 0/3] Add I2C bus lock for Wangxun Jiawen Wu
2024-08-23  3:02 ` [PATCH net 1/3] net: txgbe: add IO address in I2C platform device data Jiawen Wu
2024-08-23 14:14   ` Andy Shevchenko
2024-08-23  3:02 ` [PATCH net 2/3] i2c: designware: add device private data passing to lock functions Jiawen Wu
2024-08-23 14:06   ` Andy Shevchenko [this message]
2024-08-27 13:24   ` Paolo Abeni
2024-08-29  5:16   ` kernel test robot
2024-08-23  3:02 ` [PATCH net 3/3] i2c: designware: support hardware lock for Wangxun 10Gb NIC Jiawen Wu
2024-08-23 14:13   ` Andy Shevchenko
2024-08-29  9:15     ` Jiawen Wu
2024-08-29 10:59       ` 'Andy Shevchenko'
2024-08-23 11:04 ` [PATCH net 0/3] Add I2C bus lock for Wangxun Jarkko Nikula
2024-08-27  2:26   ` Jiawen Wu
2024-08-26  1:32 ` Andrew Lunn
2024-08-26  2:04   ` Jiawen Wu
2024-08-26  2:33     ` Andrew Lunn
2024-08-27  2:21       ` Jiawen Wu
2024-08-27 12:18         ` Andrew Lunn
2024-08-29  6:40           ` Jiawen Wu
2024-08-29 15:27             ` Andrew Lunn
2024-09-03  6:31               ` Jiawen Wu
2024-09-03 12:45                 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsiXgHDZi8DpgOWs@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=duanqiangwen@net-swift.com \
    --cc=edumazet@google.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jsd@semihalf.com \
    --cc=kuba@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mengyuanlou@net-swift.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=piotr.raczynski@intel.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).