From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA3D318FDD6 for ; Fri, 23 Aug 2024 18:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724436134; cv=none; b=AL4HJ58UXyZW9mKrye4LsDPp7/xr6SUy2xKAu4VZS5f8DEBSor3pepdlUlKPTtFZ24TShavjwafDrgb7O7Gbo/gxcZu9xmDvC9OkqWAN6/uu56eUrrGWKPNuBpv2pdPpPKud0zvF9ZkDc7iTo3MsrNxk9bfKiEA4/pLUo2iGdbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724436134; c=relaxed/simple; bh=KFzisPDMHJo7Ln/wIh4AWQVO8V7I807m5GrKhyN8ij8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qlFci61ScO0DR2TlRZFUsqTtmaIMtVmHektrBZIrZNhNq1lgMh8HKjVWi4QoG6N6F6ojOm0wDcCxKVbQzv4v2ZaRkI5iYW79Q9LqyrWc6HYDbUijszuwZoI0ry9cip1pGuYgCOeyfOK0fuRmc6IHd842g5/ffXaxus4fQ3MqVIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=l27QRTqJ; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="l27QRTqJ" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5bed83488b6so2926498a12.2 for ; Fri, 23 Aug 2024 11:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1724436131; x=1725040931; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=chz6WNcKqUHubBnvxXzbFav7NB3CIhhztw7hfQz7I5k=; b=l27QRTqJRTTUaiTKpACtd8J3FUkDUDPzEGPK4pPrp44NcNINlNuoSBJoVWAcjg1cDM SM7DaqTr3jnKTQKM1PhtrnTcJ4eeqEC15ltlplRiHgPlS5bgd2zr3VWkLeGanWDVJxK0 tSc/kuFODF7dlcZr67az1SAlHNOklIMOlgfoI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724436131; x=1725040931; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=chz6WNcKqUHubBnvxXzbFav7NB3CIhhztw7hfQz7I5k=; b=BihPQcM19r3v+mtR2QWL0gdsgHgo66DJuoDlswPiRL7Luw8pq2HcJU6tTJhbHvPQSX zP2/Vbof5MKAT8L0rvLdkEP7GVaMSKl6zZspCvHWZr2gIBsIoEdR/iydoY+zinigDjCN Wr8MkRrHb/1CzaLuiUl+6236ls5mAXLE+TrKp3HPK5mnjcMzM3IDtzT8M42/Y219ktnP gVowLqd7JTq/fQP/BXms9zTyYlklFihiBMbFm71+cxI+llxRNyeVydAjuPzQ56K2ZUVT TORA1GdgCXYawSr+JhVrDfA24pqO1q5+eRKRMJohEoU52kiNaOmde/jTx/80chffEq6N QJQA== X-Gm-Message-State: AOJu0YxPC5gi4ow8hdxT8kIZOloNAz3by3FoGowEkJvdUir2LeiS3hzn H0uwG7sBVxCbbCgD4ox2vrFrnPI95jH6gpFqVon299N0KRJ2wAWkpSw+3N+xJs8= X-Google-Smtp-Source: AGHT+IHLmogsSLL4RG6OHQXTCvoGTD7y9oeQstqmNv9alfhru+JJ/kqYHZ2RPkrU6o+dIL+xFV2BAw== X-Received: by 2002:a05:6402:2743:b0:5c0:88fe:261b with SMTP id 4fb4d7f45d1cf-5c0891637dbmr1859486a12.11.1724436130569; Fri, 23 Aug 2024 11:02:10 -0700 (PDT) Received: from LQ3V64L9R2 ([185.226.39.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a4c43e7sm2387276a12.70.2024.08.23.11.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 11:02:10 -0700 (PDT) Date: Fri, 23 Aug 2024 19:02:08 +0100 From: Joe Damato To: Eric Dumazet Cc: netdev@vger.kernel.org, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Paolo Abeni , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Daniel Borkmann , open list Subject: Re: [PATCH net-next 3/6] net: Add control functions for irq suspension Message-ID: Mail-Followup-To: Joe Damato , Eric Dumazet , netdev@vger.kernel.org, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Paolo Abeni , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Daniel Borkmann , open list References: <20240823173103.94978-1-jdamato@fastly.com> <20240823173103.94978-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Aug 23, 2024 at 07:56:32PM +0200, Eric Dumazet wrote: > On Fri, Aug 23, 2024 at 7:31 PM Joe Damato wrote: > > > > From: Martin Karsten > > > > The napi_suspend_irqs routine bootstraps irq suspension by elongating > > the defer timeout to irq_suspend_timeout. > > > > The napi_resume_irqs routine effectly cancels irq suspension by forcing > > the napi to be scheduled immediately. > > > > Signed-off-by: Martin Karsten > > Co-developed-by: Joe Damato > > Signed-off-by: Joe Damato > > Tested-by: Joe Damato > > Tested-by: Martin Karsten > > --- > > You have not CC me on all the patches in the series, making the review > harder then necessary. My sincere apologies, Eric, and thank you for your time reviewing this. I used a script I'd been using for a while to generate the CC list, but it clearly has a bug. For any future revisions I will be sure to explicitly include you.