From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB081BF317 for ; Fri, 30 Aug 2024 20:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725049392; cv=none; b=eTfmZzXVX/sKjgCzX8hEqjyzYMvmniP3Vx4TExOVXEIo+r76a134a707Up5bqHW62rAj3n3+0hNYHkiE2UT6IMBQHJ8zdjO8lVU4LHw3/AoPjSiRuYIifqgAyis/gX+sTlDa0mnld4VtYoutEdCNSgNApQiiJXphJaswvqzrO4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725049392; c=relaxed/simple; bh=HHYq4lIrZwUIErDY1ULmrAi648bU5zYQhpY1dD2LPpc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QRdRHcxMAVtaNtFOmUop9I/pLqHN7eqcETln6bK8TUYmKyy5a8YF45qaH/aLpgJUlgfa/w0PEpmSERH8UmXDWgy0UYD+vdGR7EXNyLufDrMLmdyFtKtO4cWfjZUbE9BYLux2GKtG/3kDTO2iFGK8s4yaAoGhSYOfeKIgZExtgpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=du7skpTb; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="du7skpTb" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-428e1915e18so18581955e9.1 for ; Fri, 30 Aug 2024 13:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1725049389; x=1725654189; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=dY4Amw8gJOTj4PW7gZjzdrs3IbXEA4NCHp+pehDFrvw=; b=du7skpTbEpk+pZUFfllz+7KsRCSCsTg9hJ97ZEiWzE3RurbqxGRxZpT1CFz7nGdzWw syl4fXugTpL+MbYm3ktxoa73nOLn/1fuvv4zuYzM+yY+8e5v7TVsfDigU2B7u17HBLSr vUahZb9sRTmLJ7fqr6dimMknOqPaO56k829ho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725049389; x=1725654189; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dY4Amw8gJOTj4PW7gZjzdrs3IbXEA4NCHp+pehDFrvw=; b=DIHg3zXQtSYsdFqDGHr189/YIxXYidZZpEJDxZ3QszW7RUNHSmCJlKT+d7y85ugICu MrUPrsRzXrSlT1Km8tzT3IyyVlUuGg+7v71tAPhLv1+h2oa48yjN3y/437hMj/Mn7LFe Y2JaI0C8bzbHPfu1kVGH+Ejw2g9HNbdjI4/67OXuxprpJYRSO2rwyQSIdQpBPAwEqKHP WRYvxkVEfGm4SQRp6a/qu6DvCCcfkuFPGLTN9no94QlcNN/D7a4Xkt2u4MCo9Tp4zlBn PLInTBy6h9pFfb3LJMjKlN6Oe/TE+QXpoe/p4uAGG6Gogvt9977c69rl9/28w2+aOpuP 55pQ== X-Gm-Message-State: AOJu0YwmX+N4Zj2oyQj645N/mnARdtpEwtE2+6OFh3AxfeDTadeClBpL LIZFV7BS+qxTVntTCmDZHsYSC/1OJ1g4az0gevnI/uTutxol2vreaLW6ryvySD0= X-Google-Smtp-Source: AGHT+IGTSnX9q2OLrTowkKkFCORzR3kOVTXj22YgCrsao2yn/enJOfKgrgmkn+96CYDGjR+J1G9oEA== X-Received: by 2002:a5d:4706:0:b0:371:8e8b:902c with SMTP id ffacd0b85a97d-374bf1c954fmr33972f8f.38.1725049388241; Fri, 30 Aug 2024 13:23:08 -0700 (PDT) Received: from LQ3V64L9R2 ([185.226.39.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df1066sm56001045e9.18.2024.08.30.13.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 13:23:07 -0700 (PDT) Date: Fri, 30 Aug 2024 21:23:06 +0100 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, Martin Karsten , "David S. Miller" , Paolo Abeni , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Breno Leitao , Johannes Berg , Alexander Lobakin , open list Subject: Re: [PATCH net-next 1/5] net: napi: Make napi_defer_hard_irqs per-NAPI Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, Martin Karsten , "David S. Miller" , Paolo Abeni , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Breno Leitao , Johannes Berg , Alexander Lobakin , open list References: <20240829131214.169977-1-jdamato@fastly.com> <20240829131214.169977-2-jdamato@fastly.com> <20240829150502.4a2442be@kernel.org> <20240830132112.0ee08109@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830132112.0ee08109@kernel.org> On Fri, Aug 30, 2024 at 01:21:12PM -0700, Jakub Kicinski wrote: > On Fri, 30 Aug 2024 10:14:41 +0100 Joe Damato wrote: > > Otherwise: I'll make them static inlines as you suggested. > > > > Let me know if you have a preference here because I am neutral. > > No strong preference either, static inlines seem like a good > middle ground :) Ack. Already queued up in my v2 branch.