From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C830F1448C7 for ; Thu, 5 Sep 2024 03:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725507495; cv=none; b=j4HPmrNOb3AyBvAjti+yyz+T6LnKIe1T2Ar/xBreLAcU3GxMm2/tWrxuGEvKG4SQvFwW7elFrK4DFThNyzrAAEWpnJ7vB0kic2UrV9Pr8lgZrbYPSdOoOKIqMif8YP/0CgBSG6xgxWtoeClDkM/SAme8Vv+mGFb/r7CnrTMf4JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725507495; c=relaxed/simple; bh=mmiaJAbhrJN/bNqpFuO9uFl1R/zzhkIVpCzlW51fYOA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZOIHTOMuiXSYwn4C2rFcB4fBlSeKSXoeKlHfKDnBrtWER5BeRrIT+0HQBt/mIuJ7BqMcvedaGSHxrp1qbygBULwFqhVcoODLzuNMPbgtUfmQxcFuMTnMCc5jQ3s50fjG7vSGy2O9XVoWPtvnK+fiIolvF+EJ/KnqQUDERth85/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=DMQy8RxO; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="DMQy8RxO" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2055f630934so2645865ad.1 for ; Wed, 04 Sep 2024 20:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1725507493; x=1726112293; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=08wuXpe7nVswzOQ+7NVFPT0XGolvX7IJ38IQQv3iN0o=; b=DMQy8RxOFlOTY6aka1Zvsnn2KjBFC5XZ37ShZaqY0IRv2U1vp0edmkvA3iW6qRYi6o PIyGYKG6B4WMrPDidbGd/JHwj6boLj6OUBwnOY3uSsPLiU/TgI3g5l36w4Co9PPcXVoa FLjtvtjLHCGa283kgKsFP3ovA/DXCbOcZHzaCI2TbjfvW6oORBtts3PXmRNzmbFJloH/ 42wOmBNC0PdVowUqu62rPNrPT00uc8Ow8hSnysXpF570Uve/klrSBeTGceKN1pQWo9Oy H9vHq7FL01C1yU7KbdmKUkq5ydLMIfKTVF4dWJ2AaW/zNGJnTI3gM96WYmFKyHiFI/u8 Dgzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725507493; x=1726112293; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=08wuXpe7nVswzOQ+7NVFPT0XGolvX7IJ38IQQv3iN0o=; b=rpWocXBc665ALYrLtz7s0jfS/KfhPCYqsWXyMd6/DE8NZh9cRuNJnDdAfw6cpFgnof TzSmRtBzexM5BSttLqKnzX6Z+sjxmQZf0XJwb+J+LWU12V4yXHTA6p7DQtDaaimYCkXE hMOUGimnFZtHDqoZTS63798wgFZIjKpcuaN1jpoVylLZBHdjOzCMRSIDotUoaasggMY+ 6PeuyRUtpSWV6hfE0cn1Sf5tBikUETcmbsW/IXRPNYm/wJbZOd2J6/DczlpqKmSSz3Nm dC2vk1X+5tby/XWU8Y/EwSBHpXJ91o0s4RPNVHN6Tgg1a003qoQqa8Q+UzaPL/H7SZho J3eg== X-Forwarded-Encrypted: i=1; AJvYcCXfrIdB2Ot+Rk9VDn3PzbNPatbkYSo4UtXpva0QUA5EbcPj9M3VTFKHffO04eYFwvp8iPNmJ+E=@vger.kernel.org X-Gm-Message-State: AOJu0YxWD9SGuyrhiCIRwfjjWNnoO2XeMb/giBuSaDEy5xUiRSbGiwmE eOy8xPjVAwxZAU4nYNff1e8cE5XNYzQKD2gO+j4p55ck95mBnDIeBJ6xR1p+3Nw= X-Google-Smtp-Source: AGHT+IHH3Lqn5on1g4RFU57JfQl06v4zJ/wLxbY8TMC7VJqZlFOf/eV3r5+jBfeS2045uWs4FbawQg== X-Received: by 2002:a17:902:ce82:b0:205:4e4a:72d9 with SMTP id d9443c01a7336-2054e4a795emr184195425ad.7.1725507493010; Wed, 04 Sep 2024 20:38:13 -0700 (PDT) Received: from medusa.lab.kspace.sh (c-98-207-191-243.hsd1.ca.comcast.net. [98.207.191.243]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-206aea38539sm20130665ad.130.2024.09.04.20.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 20:38:12 -0700 (PDT) Date: Wed, 4 Sep 2024 20:38:11 -0700 From: Mohamed Khalfella To: Moshe Shemesh Cc: Przemek Kitszel , yzhong@purestorage.com, Shay Drori , Saeed Mahameed , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tariq Toukan Subject: Re: [PATCH v2 0/1] net/mlx5: Added cond_resched() to crdump collection Message-ID: References: <20240829213856.77619-1-mkhalfella@purestorage.com> <43e7d936-f3c6-425a-b2ff-487c88905a0f@intel.com> <36b5d976-1fcb-45b9-97dd-19f048997588@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36b5d976-1fcb-45b9-97dd-19f048997588@nvidia.com> On 2024-08-30 12:51:43 +0300, Moshe Shemesh wrote: > > > On 8/30/2024 10:08 AM, Przemek Kitszel wrote: > > > > > On 8/30/24 01:58, Mohamed Khalfella wrote: > >> On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote: > >>> Changes in v2: > >>> - Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that > >>>    usleep_range() should be enough. > >>> - Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128 > >>>    iterations. > >>> > >>> v1: > >>> https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@purestorage.com/ > >>> > >>> Mohamed Khalfella (1): > >>>    net/mlx5: Added cond_resched() to crdump collection > >>> > >>>   drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++ > >>>   1 file changed, 4 insertions(+) > >>> > >>> -- > >>> 2.45.2 > >>> > >> > >> Some how I missed to add reviewers were on v1 of this patch. > >> > > > > You did it right, there is need to provide explicit tag, just engaging > > in the discussion is not enough. v2 is fine, so: > > Reviewed-by: Przemek Kitszel > > Reviewed-by: Moshe Shemesh > And fixes tag should be: > Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support") Will add the tag in v3.