From: Guillaume Nault <gnault@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org,
Martin Varghese <martin.varghese@nokia.com>,
Willem de Bruijn <willemb@google.com>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net] bareudp: Fix device stats updates.
Date: Fri, 6 Sep 2024 12:42:33 +0200 [thread overview]
Message-ID: <ZtrcmacoHyQkqZ0h@debian> (raw)
In-Reply-To: <20240904144839.174fdd97@kernel.org>
On Wed, Sep 04, 2024 at 02:48:39PM -0700, Jakub Kicinski wrote:
> On Wed, 4 Sep 2024 19:54:40 +0200 Guillaume Nault wrote:
> > In this context, I feel that dstats is now just a mix of tstats and
> > core_stats.
>
> I don't know the full background but:
>
> * @core_stats: core networking counters,
> * do not use this in drivers
Hum, I didn't realise that :/.
I'd really like to understand why drivers shouldn't use core_stats.
I mean, what makes driver and core networking counters so different
that they need to be handled in two different ways (but finally merged
together when exporting stats to user space)?
Does that prevent any contention on the counters or optimise cache line
access? I can't see how, so I'm probably missing something important
here.
> bareudp is a driver.
>
> > After -net will merge into net-next, I'll can convert bareudp to either
> > dstats or tstats, depending on the outcome of this conversation.
>
> Sure.
>
next prev parent reply other threads:[~2024-09-06 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 15:31 [PATCH net] bareudp: Fix device stats updates Guillaume Nault
2024-08-31 14:56 ` Willem de Bruijn
2024-09-03 18:34 ` Jakub Kicinski
2024-09-04 12:29 ` Guillaume Nault
2024-09-04 14:57 ` Jakub Kicinski
2024-09-04 17:54 ` Guillaume Nault
2024-09-04 21:48 ` Jakub Kicinski
2024-09-06 10:42 ` Guillaume Nault [this message]
2024-09-06 12:47 ` Eric Dumazet
2024-09-10 10:28 ` Guillaume Nault
2024-09-05 1:50 ` David Ahern
2024-09-06 10:30 ` Guillaume Nault
2024-09-04 22:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtrcmacoHyQkqZ0h@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).