From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26CE2144D0A for ; Wed, 11 Sep 2024 07:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726038054; cv=none; b=r1GAbKv9JsA1lk/UMAwWQztgRjsPBHcx5GIMOvAefb+OOgtazvNxRX2BtQalEsED4RFGUVNeTe1qVESkqh3i1ob4d/kAHSeg9+VAvh3melsz+AjR/+7QXvNeE1v2TxZkiSHReKqfgM5fRoHm/BJGhHkWGtCPJzC0JvK370Eqbv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726038054; c=relaxed/simple; bh=haGjOs6Ls3rcFJQz1O4SXqDm7eC9DDi3NlIAUroJ10U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bTpxv04rKNycOtG5RIPXPyx+l3KTCwtP4f4wy+1vOVL5kIvBt+QCSGzWKey0yvKDy+ILF1GjL6q6LBPc4ZNLaGhc0XvzhNEVUaSoHX5YLH/Jn+Wge3e34EsB2HtEVFa/Jowxr4VV1ih785Z0c1Qe0rgtJpoE+sOVxYQah6sy32Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1soHKt-0000rM-6F; Wed, 11 Sep 2024 09:00:19 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1soHKr-0074hk-Pm; Wed, 11 Sep 2024 09:00:17 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1soHKr-001pNS-2C; Wed, 11 Sep 2024 09:00:17 +0200 Date: Wed, 11 Sep 2024 09:00:17 +0200 From: Oleksij Rempel To: Rob Herring Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: ethernet-phy: Add master-slave role property for SPE PHYs Message-ID: References: <20240909124342.2838263-1-o.rempel@pengutronix.de> <20240909124342.2838263-2-o.rempel@pengutronix.de> <20240909162009.GA339652-robh@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Tue, Sep 10, 2024 at 11:54:04AM -0500, Rob Herring wrote: > On Mon, Sep 9, 2024 at 12:00 PM Andrew Lunn wrote: .... > > The 2022 revision of 802.3 still has master/slave when describing the > > registers, but it does have Annex K as described above saying "leader" > > and "follower" are optional substitutions. > > > > The Linux code has not changed, and the uAPI has not changed. It seems > > like the best compromise would be to allow both 'force-master' and > > 'force-leader', as well as 'force-slave' and 'force-follower', and a > > reference to 802.3 Annex K. > > It seems silly to maintain both forever. I'd rather have one or the > other than both. I'll accept what ever will be decided. Even if we will decide to use words 'leader' and 'follower' for the properties, we still need to document that they correspond to 'master' and 'slave' in the IEEE specification and in the kernel UAPI. I can imagine a mdi-link-clock-role = 'leader' or 'follower' > > As to you comment about it being unclear what it means i would suggest > > a reference to 802.3 section 1.4.389: > > > > 1.4.389 master Physical Layer device (PHY): Within IEEE 802.3, in a > > 100BASE-T2, 1000BASE-T, 10BASE-T1L, 100BASE-T1, 1000BASE-T1, or any > > MultiGBASE-T link containing a pair of PHYs, the PHY that uses an > > external clock for generating its clock signals to determine the > > timing of transmitter and receiver operations. It also uses the > > master transmit scrambler generator polynomial for side-stream > > scrambling. Master and slave PHY status is determined during the > > Auto-Negotiation process that takes place prior to establishing the > > transmission link, or in the case of a PHY where Auto-Negotiation is > > optional and not used, master and slave PHY status > > phy-status? Shrug. In my understanding, the 'status' is result not actual configuration request. > Another thought. Is it possible that h/w strapping disables auto-neg, > but you actually want to override that and force auto-neg? Yes. If I would need it, I would recommend to have a different override property, something like: autoneg-default = 'on' or 'off' Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |