From: Ido Schimmel <idosch@nvidia.com>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: kuba@kernel.org, aleksander.lobakin@intel.com, horms@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, dongml2@chinatelecom.cn, amcohen@nvidia.com,
gnault@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com,
razor@blackwall.org, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 06/12] net: vxlan: make vxlan_snoop() return drop reasons
Date: Wed, 11 Sep 2024 11:08:20 +0300 [thread overview]
Message-ID: <ZuFP9EAu4MxlY7k0@shredder.lan> (raw)
In-Reply-To: <20240909071652.3349294-7-dongml2@chinatelecom.cn>
On Mon, Sep 09, 2024 at 03:16:46PM +0800, Menglong Dong wrote:
> @@ -1447,7 +1448,7 @@ static bool vxlan_snoop(struct net_device *dev,
>
> /* Ignore packets from invalid src-address */
> if (!is_valid_ether_addr(src_mac))
> - return true;
> + return SKB_DROP_REASON_VXLAN_INVALID_SMAC;
[...]
> diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
> index 98259d2b3e92..1b9ec4a49c38 100644
> --- a/include/net/dropreason-core.h
> +++ b/include/net/dropreason-core.h
> @@ -94,6 +94,8 @@
> FN(TC_RECLASSIFY_LOOP) \
> FN(VXLAN_INVALID_HDR) \
> FN(VXLAN_VNI_NOT_FOUND) \
> + FN(VXLAN_INVALID_SMAC) \
Since this is now part of the core reasons, why not name it
"INVALID_SMAC" so that it could be reused outside of the VXLAN driver?
For example, the bridge driver has the exact same check in its receive
path (see br_handle_frame()).
> + FN(VXLAN_ENTRY_EXISTS) \
> FN(IP_TUNNEL_ECN) \
> FNe(MAX)
next prev parent reply other threads:[~2024-09-11 8:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 7:16 [PATCH net-next v3 00/12] net: vxlan: add skb drop reasons support Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 01/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 06/12] net: vxlan: make vxlan_snoop() " Menglong Dong
2024-09-11 8:08 ` Ido Schimmel [this message]
2024-09-12 2:30 ` Menglong Dong
2024-09-13 9:13 ` Menglong Dong
2024-09-14 9:33 ` Simon Horman
2024-09-16 4:39 ` Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 07/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() Menglong Dong
2024-09-14 9:30 ` Simon Horman
2024-09-16 4:38 ` Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() Menglong Dong
2024-09-09 7:16 ` [PATCH net-next v3 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuFP9EAu4MxlY7k0@shredder.lan \
--to=idosch@nvidia.com \
--cc=aleksander.lobakin@intel.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).