netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
	netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next 12/13] selftests: ncdevmem: Move ncdevmem under drivers/net
Date: Fri, 13 Sep 2024 10:19:06 -0700	[thread overview]
Message-ID: <ZuR0ClWpxEk2I179@mini-arch> (raw)
In-Reply-To: <CAHS8izNTgbf-654fB84Wiz1kgA4z5HoicDm_MuGS_72561AnuA@mail.gmail.com>

On 09/13, Mina Almasry wrote:
> On Thu, Sep 12, 2024 at 10:13 AM Stanislav Fomichev <sdf@fomichev.me> wrote:
> >
> > This is where all the tests that depend on the HW functionality live in
> 
> Is this true? My impression is that selftests/net verifies core
> functionality and drivers/net verifies more lower level driver
> (specific?) functionality. There are tests in selftests/net that
> depend on HW functionality, I think like bpf_offload.py.
> 
> devmem tcp in my mind is primarily a core functionality and a lot of
> effort was put into making the driver bits of it as minimal as
> possible. Is there a need to move it or is this preference?

I'm wrong and it is actually drivers/net/hw, not drivers/net. But yes,
the driver/net/hw is the directory for the tests that depend on some
HW functionality (NIPA doesn't run the tests in this directory; but
the vendors eventually will). And until/if we get to loopback mode [1],
there is no way to run ncdevmem without special HW :-(

1: https://lore.kernel.org/netdev/20240913150913.1280238-5-sdf@fomichev.me/T/#m4fc52463857c19ad432db656c433cffdf74477a4

  reply	other threads:[~2024-09-13 17:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 17:12 [PATCH net-next 00/13] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 01/13] selftests: ncdevmem: Add a flag for the selftest Stanislav Fomichev
2024-09-12 20:36   ` Mina Almasry
2024-09-12 21:59     ` Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 02/13] selftests: ncdevmem: Remove validation Stanislav Fomichev
2024-09-12 20:36   ` Mina Almasry
2024-09-12 21:57     ` Stanislav Fomichev
2024-09-13 15:30       ` Mina Almasry
2024-09-13 17:15         ` Stanislav Fomichev
2024-09-13 23:42           ` Mina Almasry
2024-09-12 17:12 ` [PATCH net-next 03/13] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 04/13] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-09-12 20:36   ` Mina Almasry
2024-09-12 17:12 ` [PATCH net-next 05/13] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-09-12 20:35   ` Mina Almasry
2024-09-12 21:49     ` Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 06/13] selftests: ncdevmem: Remove client_ip Stanislav Fomichev
2024-09-12 20:35   ` Mina Almasry
2024-09-12 21:48     ` Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 07/13] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 08/13] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 09/13] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 10/13] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-09-14 13:14   ` kernel test robot
2024-09-12 17:12 ` [PATCH net-next 11/13] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-09-12 20:34   ` Mina Almasry
2024-09-12 21:47     ` Stanislav Fomichev
2024-09-26 16:26       ` Mina Almasry
2024-09-27  1:20         ` Stanislav Fomichev
2024-09-12 17:12 ` [PATCH net-next 12/13] selftests: ncdevmem: Move ncdevmem under drivers/net Stanislav Fomichev
2024-09-13 15:38   ` Mina Almasry
2024-09-13 17:19     ` Stanislav Fomichev [this message]
2024-09-12 17:12 ` [PATCH net-next 13/13] selftests: ncdevmem: Add automated test Stanislav Fomichev
2024-09-12 20:34   ` Mina Almasry
2024-09-12 19:48 ` [PATCH net-next 00/13] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-09-12 21:07   ` Mina Almasry
2024-09-12 21:43     ` Stanislav Fomichev
2024-12-13  1:18       ` Stanislav Fomichev
2024-12-13 17:47         ` Mina Almasry
2024-12-13 18:53           ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuR0ClWpxEk2I179@mini-arch \
    --to=stfomichev@gmail.com \
    --cc=almasrymina@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).