From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36EC92D045; Tue, 17 Sep 2024 14:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726583473; cv=none; b=cCYy1pxsUpVvgYDhZ170ctX+ghcsFjvJiqP0rlO+rX0QVmWEnkI8g8sIjwBzT++bLPL7Y8NzrV6tITJfwdm/06EHfAizpgJe4NIAQeqnXdDSNi1R6XKMQU2/9nCMhVAQaYC1zWPcC6Tsni7HKWtLAAOE5gijJ58X/qwDBZkAANg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726583473; c=relaxed/simple; bh=VMVSMHRhvQ//jxoJEy7uMeB+L9xvlZ2KEl2QDTjI+wc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RwA2Jj4qjTfcFDJy259sCd/6Eq+om9V7J+WMTTvxSN/HjAitRMtNDzSc2vhtCLimNb9FvRc7aY/NKpdGjQaO2XhKaW7pnYsONtLrbTXIcEOjhD28pD6HYh+wHb/9BQmrcl8NN0CDnO6vS9Bnj5orHnI3sn+FBqqZsj2+9JmVA6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=Of7yR8Jg; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Of7yR8Jg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w6IvVu9+p7my0rLi2hz8x9RaDYdKgEtiSkEPRYHcrkA=; b=Of7yR8JgJmukosSr4YTLLLA9T/ IFes/3WECyfMM8gJAxqqTYm7G2KeEfYvD6OOe8hcGScPHbKqtpLQkkhp+UUOx210HmJfCU088JNFL qXmmRK0TGgSZ56ili0NNfQyQnPCtAOJFPly7H1Cw5ThjKN/IQn/8coJAP9fS8VZEMb31/IWy0foTY VuWCF4Y0aSYpxMADNOasxP/w0QbfB7Kbro5yW52dke7CVFCbHh4MNw0FLNj4aXhtm13ng3Mt8KYoo 5aCzCMTvOvnz78e9e+cUbSYIpspG5vt+TxiUNAz+TpyBMQVltX4cKV+YlBNsJqe1N6WEyLZboC1aR Kw41Cf9Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37242) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sqZEK-000714-10; Tue, 17 Sep 2024 15:31:01 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1sqZEI-00082q-1N; Tue, 17 Sep 2024 15:30:58 +0100 Date: Tue, 17 Sep 2024 15:30:58 +0100 From: "Russell King (Oracle)" To: Daniel Golle Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , Bartosz Golaszewski , Robert Marko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] net: phy: aquantia: fix setting active_low bit Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Tue, Sep 17, 2024 at 02:49:40PM +0100, Daniel Golle wrote: > phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting > in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit. > Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit. > > Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs") > Signed-off-by: Daniel Golle Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!