From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67A31607BD for ; Tue, 17 Sep 2024 16:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726589181; cv=none; b=oQlGgFwjNlZHRsD597FSqQZ8sv34swgh5QSJQvlaHzvtMWZB/IZeI/yX0G3kHZTmmXwFcWmxBx7UMdy7M+RV+/QHVJ2BcoNJnGP48TBYaBfrrZvBEpHWhPiV0EqBX+DDa3UA40yUyMWQDu5jR8W1oxj4YYwAYYTDG6OQmAN4LMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726589181; c=relaxed/simple; bh=32AEDX9cCv9RsZHT9wdTvhGXqMlN0xLTW5QkFMjL/4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UzMs2xngGuj9vLcpFLG+ezsFA05lHzwENd/DN8Qq7ZTsB9TchL+cOA6vh7DbRjESH5vTbF+BtDtAQG0xqqYJRe+FDKX5r7Oj/ayVb2BezHOgvfxeFuiEskBSbCf3riMV/xAE41TEbq7ZwCwJJAM5XcOZUoqYZHqGzAo+yD2dDl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=Btj9KYxV; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="Btj9KYxV" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-374c7e64b60so3482718f8f.2 for ; Tue, 17 Sep 2024 09:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1726589178; x=1727193978; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C3wWVmY11x7twX+QLzZLt+655E3mj9zAVsD71Ldt/Ac=; b=Btj9KYxVw2j9NpKleB/T4folXDUm1hDLKUOF5p0UP0rZmRW2zo9kKiUcb4zFCbI0HH 6DSW1IUTCDDH6VWtfXz0WH3NhmVcbyV/iVYT0lXpFgiysn5nRfnPokS8WJZJ1bpuldDJ usBcdZhn6U3VR6hG//rwzv6qNn1mlhSUP1mMZmGEECdbnLyPQvbY+Zg2oQ4o2RZKI2pj mLOXrXarn9A8BBN95HQTDi/FNFBlTSHIXTg5vXCW36ggChLGOrR0cDzqkQYrimAVoBwK TWbSSy8B5M46b/bGT6pj3puG6ytURDoRQ2hNtmFxWgUzNOVW22NSRdS/dG4l6Xo295gp pykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726589178; x=1727193978; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C3wWVmY11x7twX+QLzZLt+655E3mj9zAVsD71Ldt/Ac=; b=BQrHwuiOm2pr10r/LHiPavVobFeyACwUCrhXEWYNLbuCRmuGgZIaX+mQGiq588fQbR nUa/9PCmd3jX4V/Y6KiUn27H5MhWaM+/fbXS1PwsuQghfGfUuyKbOeyH1S8FG7/BiVpl U3xr31hbcmHl+DkjMSOD4gi1Lwwt71IDtlQsxG/qITDQ4XqIQ/ta+mGWHir3hH+Y9OF8 z+gIPy3JSeESIJPGhRWYQRrV1mzDIgYiBsiOmjhL6fY0r1AfcoDLQGG6oEED89DuoDCm A1xo0N+iG37TFOas3Abdgy/wx8lfTGeormmm/kZYtHHSjPRWov1F+OSGkFLvlgCDbNAS r5vg== X-Forwarded-Encrypted: i=1; AJvYcCU9IBnVCVTa0s12obp336cstjTP7IPAKyexUq8W6AbjtL6ODLSsE/Qpi15+oycWZ+dUtlcvKgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwpOwO/Zs+GIKKovPFGeuppVwKrYHqqXUK7zuRmerUk+YKmwZ2S FUmh/L0gQDi8Nh5c4CGRhEOzpsfVQCNXhXM8A75h7jOhlI8j179M/mUxZcAzKL4= X-Google-Smtp-Source: AGHT+IFBa6LORWITRw1wV+KPnnRiX0GK6peQ486VSUGuguJIiXw3h4Apf2WbrzFK92EDTfdpTnDLRA== X-Received: by 2002:adf:a45d:0:b0:374:c847:848 with SMTP id ffacd0b85a97d-378c2d5a70dmr9566997f8f.36.1726589177899; Tue, 17 Sep 2024 09:06:17 -0700 (PDT) Received: from GHGHG14 ([2a09:bac5:50ca:432::6b:83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e7800138sm9857539f8f.68.2024.09.17.09.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 09:06:17 -0700 (PDT) Date: Tue, 17 Sep 2024 17:06:14 +0100 From: Tiago Lam To: Simon Horman Cc: "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Jakub Sitnicki , kernel-team@cloudflare.com Subject: Re: [RFC PATCH 2/3] ipv6: Run a reverse sk_lookup on sendmsg. Message-ID: References: <20240913-reverse-sk-lookup-v1-0-e721ea003d4c@cloudflare.com> <20240913-reverse-sk-lookup-v1-2-e721ea003d4c@cloudflare.com> <20240914085950.GC12935@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240914085950.GC12935@kernel.org> On Sat, Sep 14, 2024 at 09:59:50AM +0100, Simon Horman wrote: > On Fri, Sep 13, 2024 at 10:39:20AM +0100, Tiago Lam wrote: > > This follows the same rationale provided for the ipv4 counterpart, where > > it now runs a reverse socket lookup when source addresses and/or ports > > are changed, on sendmsg, to check whether egress traffic should be > > allowed to go through or not. > > > > As with ipv4, the ipv6 sendmsg path is also extended here to support the > > IPV6_ORIGDSTADDR ancilliary message to be able to specify a source > > Hi Tiago Lam, > > Some minor nits from my side. > > ancilliary -> ancillary > > Likewise in patch 3/3. > Flagged by checkpatch.pl --codespell > > > address/port. > > > > Suggested-by: Jakub Sitnicki > > Signed-off-by: Tiago Lam > > --- > > net/ipv6/datagram.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > net/ipv6/udp.c | 8 ++++-- > > 2 files changed, 82 insertions(+), 2 deletions(-) > > > > diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c > > index fff78496803d..4214dda1c320 100644 > > --- a/net/ipv6/datagram.c > > +++ b/net/ipv6/datagram.c > > @@ -756,6 +756,27 @@ void ip6_datagram_recv_ctl(struct sock *sk, struct msghdr *msg, > > } > > EXPORT_SYMBOL_GPL(ip6_datagram_recv_ctl); > > > > +static inline bool reverse_sk_lookup(struct flowi6 *fl6, struct sock *sk, > > + struct in6_addr *saddr, __be16 sport) > > +{ > > + if (static_branch_unlikely(&bpf_sk_lookup_enabled) && > > + (saddr && sport) && > > + (ipv6_addr_cmp(&sk->sk_v6_rcv_saddr, saddr) || inet_sk(sk)->inet_sport != sport)) { > > Please consider, where it can trivially be achieved, limiting Networking > code to 80 columns wide. > > Checkpatch can be run with a flag to check for this. > Thanks for the hints here, I've addressed these and will include the changes into the next revision. I use b4 which takes care of some of this checks, but I'll make sure I change my settings to use `--max-line-length=80` as well. Tiago.