From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C91FC1A0722 for ; Thu, 3 Oct 2024 15:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727970376; cv=none; b=bQB/M2QRdR5IiBZWG2EDNCadolVQOXjRvoonffuzpG4CXuxQjjUnyWrccuZwpFgfMg6nFyFKoH0326d53zt0vpEwIYdQjtzIy98sm820tpHmbdxteBVwMZvlyyCAP1jLiEBK0aVNZFnxlFF+zd1X1HTlRIzH3vEk6e+TXBAfAm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727970376; c=relaxed/simple; bh=c24CSpB9u0bQiRjmqj4Py3erZup2Nm7AdiMa7TDZqlc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iyDNjaf+U0yp5p1b3Y3JWa1Ugx8l71CjoxZdBAForCteMEu1se88ZmWt5xz0mfD+aESR+Ox1gdGNdP+1XyRal14WDP7sqxK4EJgh3b+j0OnZy6T9G+SPfJfVeDwWOFucVJ7b077ETkmLeSvVkSrSWhtJEMDuQ+PwFE3Eu07KbQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=bH7ch1Uv; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="bH7ch1Uv" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b4a0940e3so10284345ad.0 for ; Thu, 03 Oct 2024 08:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1727970374; x=1728575174; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=vg9O2bmhocfO75+5ltClKdx7MUK6nTYdplQZgbhltGY=; b=bH7ch1UvbPWdf0yI/yx4DtUYaJPGbkMnUJOB00qULLvwiSl4PwbV7YXaXDIT9XFb4s cKsmjLCYzzMVqXLzCOhIrPtv5PgxI3E5ETiqBi9X7PUguxCA9sM/Ma08SkwOFaqm6q70 mDtwK+WbmXrTQbTCUgC7ZEz54ENXm1jiPdGjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727970374; x=1728575174; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vg9O2bmhocfO75+5ltClKdx7MUK6nTYdplQZgbhltGY=; b=VDanjo76uQGsKE2iy7jIHhyfDPPWnIRYosZehbnqENMVI1t3VrimyU31d3gS9G9JgP oN/Z14+7e+ykkBes8Peee5AFxqp+io7g4DP6EHysu7asnlhpMiot3jx6SpNPLTSyKzfw YmaGboQatxMvxaCtApPMUHhgy2HAWnGJ8HNO/Va8cfDPeIyhTSTr32kQ2Wvgr/uXzBzV wzgxAY7LNnXcCejE+viDuE/7FJaL27aMxHQrm7BY28ZqgYn1v039MEnI8qj6WEQpyNhl w5RbgJWVein4W03uUz/83UHMAXrxhF6qDQaU6ndQPgaeBGEm9rlDIAICZc9hiev01ggn M0yg== X-Forwarded-Encrypted: i=1; AJvYcCVxusX6dPSQB2NC52EZTncqGMwgqyb6ArlsS5E7AibMrubnQMvwsPb8Y6cf//xYrjOpFxyVlTI=@vger.kernel.org X-Gm-Message-State: AOJu0YzvhGiLtRbzLml/OQSOPicDdeSMPAq4A5xncDpFaKJztND/HKry 2nctnadKVSxhZhH0i2eZ4FEh2skLy0zUNy2cVuS93pNg8q+OuiAxOgYI15hPAkk= X-Google-Smtp-Source: AGHT+IHJZ2Cva6weRJymSIYfRl+TvfkC3DsPe7+bV+X6mtLTATN118ZY6+JXSzlo5Pl23BKacVdE6A== X-Received: by 2002:a17:902:e84b:b0:20b:937e:ca1e with SMTP id d9443c01a7336-20bc5a0a801mr103188475ad.18.1727970374142; Thu, 03 Oct 2024 08:46:14 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20beeca2256sm10523285ad.91.2024.10.03.08.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 08:46:13 -0700 (PDT) Date: Thu, 3 Oct 2024 08:46:11 -0700 From: Joe Damato To: Alexander Lobakin Cc: Jakub Kicinski , Przemek Kitszel , netdev@vger.kernel.org, Tony Nguyen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list , Simon Horman Subject: Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size Message-ID: Mail-Followup-To: Joe Damato , Alexander Lobakin , Jakub Kicinski , Przemek Kitszel , netdev@vger.kernel.org, Tony Nguyen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list , Simon Horman References: <20240925180017.82891-1-jdamato@fastly.com> <20240925180017.82891-2-jdamato@fastly.com> <6a440baa-fd9b-4d00-a15e-1cdbfce52168@intel.com> <9f86b27c-8d5c-4df9-8d8c-91edb01b0b79@intel.com> <20241002101727.349fc146@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 03, 2024 at 03:35:54PM +0200, Alexander Lobakin wrote: [...] > napi_struct is the only generic struct whichs size is hardcoded in the > macros (struct dim is already sizeof()ed, as well as cpumask_var_t), so > I'm fine with the change you proposed in your first RFC -- I mean > > libeth_cacheline_set_assert(struct idpf_q_vector, 112, > - 424 + 2 * sizeof(struct dim), > + 24 + sizeof(struct napi_struct) + > + 2 * sizeof(struct dim), > 8 + sizeof(cpumask_var_t)); So you are saying to drop the other #defines I added in the RFC and just embed a sizeof? I just want to be clear so that I send a v2 that'll be correct.