[PATCH net] net: pcs: xpcs: fix the wrong register that was written back

[PATCH net] net: pcs: xpcs: fix the wrong register that was written back

[Jiawen Wu]

The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
written back to TXGBE_RX_GEN_CTL3 when it changes some fields.

Cc: stable@vger.kernel.org
Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/pcs/pcs-xpcs-wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pcs/pcs-xpcs-wx.c b/drivers/net/pcs/pcs-xpcs-wx.c
index 19c75886f070..5f5cd3596cb8 100644
--- a/drivers/net/pcs/pcs-xpcs-wx.c
+++ b/drivers/net/pcs/pcs-xpcs-wx.c
@@ -109,7 +109,7 @@ static void txgbe_pma_config_1g(struct dw_xpcs *xpcs)
 	txgbe_write_pma(xpcs, TXGBE_DFE_TAP_CTL0, 0);
 	val = txgbe_read_pma(xpcs, TXGBE_RX_GEN_CTL3);
 	val = u16_replace_bits(val, 0x4, TXGBE_RX_GEN_CTL3_LOS_TRSHLD0);
-	txgbe_write_pma(xpcs, TXGBE_RX_EQ_ATTN_CTL, val);
+	txgbe_write_pma(xpcs, TXGBE_RX_GEN_CTL3, val);
 
 	txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL0, 0x20);
 	txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL3, 0x46);
-- 
2.27.0

Re: [PATCH net] net: pcs: xpcs: fix the wrong register that was written back

[Russell King (Oracle)]

On Tue, Sep 24, 2024 at 10:28:57AM +0800, Jiawen Wu wrote:
> The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
> written back to TXGBE_RX_GEN_CTL3 when it changes some fields.
> 
> Cc: stable@vger.kernel.org

Reported-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

> Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net] net: pcs: xpcs: fix the wrong register that was written back

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 24 Sep 2024 10:28:57 +0800 you wrote:
> The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
> written back to TXGBE_RX_GEN_CTL3 when it changes some fields.
> 
> Cc: stable@vger.kernel.org
> Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> [...]

Here is the summary with links:
  - [net] net: pcs: xpcs: fix the wrong register that was written back
    https://git.kernel.org/netdev/net/c/93ef6ee5c20e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html