From: Hangbin Liu <liuhangbin@gmail.com>
To: Kacper Ludwinski <kacper@ludwinski.dev>
Cc: davem@davemloft.net, kuba@kernel.org, vladimir.oltean@nxp.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Fix issue related with assigning two diffrent vids to the same interface.
Date: Thu, 26 Sep 2024 02:12:55 +0000 [thread overview]
Message-ID: <ZvTDJyKatBVpgqMj@fedora> (raw)
In-Reply-To: <20240925050539.1906-1-kacper@ludwinski.dev>
Hi Kacper,
When you post a second patch, you need to add PATCHv2 in the subject.
On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote:
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev>
> ---
> tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> index 9e677aa64a06..694ece9ba3a7 100755
> --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
> +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> @@ -202,7 +202,7 @@ one_bridge_two_pvids()
> ip link set $swp2 master br0
>
> bridge vlan add dev $swp1 vid 1 pvid untagged
> - bridge vlan add dev $swp1 vid 2 pvid untagged
> + bridge vlan add dev $swp2 vid 2 pvid untagged
>
> run_test "Switch ports in VLAN-aware bridge with different PVIDs"
>
The patch looks good to me.
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
prev parent reply other threads:[~2024-09-26 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 4:37 [PATCH] Fix issue related with assigning two diffrent vids to the same interface Kacper Ludwinski
2024-09-25 5:05 ` Kacper Ludwinski
2024-09-25 19:15 ` Simon Horman
2024-09-26 2:12 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvTDJyKatBVpgqMj@fedora \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=kacper@ludwinski.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).