From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E4AE14D6F6 for ; Thu, 26 Sep 2024 15:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365358; cv=none; b=Z2B0aZ8RbAtD37ULc+G3VnfKZKagCQQMOIN+WfZHL/7woOBMFZH6rdruH+Orff0aIWA8+lH0etUSxZaQeAppwFoWf3yiVwyCfpqQPWbUx2RUtwhPXZWE0t/kDHhtBQmSElLyU96qnses9HNF6bmpu8LF1dMc9yvHook6ALEmxe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365358; c=relaxed/simple; bh=YuuuYFG9J6VIce5wSFAppgfU6UAh20cdv9dMb/gRV8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RtwBRleTHuu5NtaMnjeyP1UvR4OzvjZFEhqlDhjAF2+/WcSjpvYZZ10VpxXSm3eD4frycQUdZ7sJfts0A896/sN7xuGbjosdKBE0VkWDmVtYntrl4jVR8Jx74WpS2zu9F1rLAwSgI/vpsc2biBHebHlJqXKf+4nWM7h3/rhA3x8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=YEXEwj5s; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="YEXEwj5s" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7d916b6a73aso740137a12.1 for ; Thu, 26 Sep 2024 08:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1727365357; x=1727970157; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=0Mlojj9wGfJRRsMDZ0gQ5kDpNUAhG0uppHae6Ab1B3Y=; b=YEXEwj5sSkdReSdTFRYnpGAAUl4aIMuDl9WwhAV006NHTSFEomnjWRFx3cjZE4BhE3 0HtJyVuWy6OkKRLdTHF/aVZgXC36jlzqTu4vy6IRmVDEPnKRDCb4WPwFpHqvWbAkInlN d/7YIxb9iR0HyQQHPIixJp55APwq9hF1F+70U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727365357; x=1727970157; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Mlojj9wGfJRRsMDZ0gQ5kDpNUAhG0uppHae6Ab1B3Y=; b=b70b4G4dM5ppiXvRqEC2DbazIYoRdd5v96S84N8Nv6R+G0lMi3J7OAKvqBCdEg11pR Wnq8swR21JzGMASrqUgCeIwG7QAoV/ThdbXIwNIb1XMUa7Ntu+EZ+HEdDMAbhybKA7ky QASVJiAmyWKdyfVSpUX1TSYqtlCKSOsKoJRRuDGItigwA1sd8Be0nAUSDOJa/CGeugPQ kD0pM00GK2SXChgvdduLzvsY5TBvYwdSX9CJ4SCrYIWY28iMCf1Bsdg8BWSQp/Pzlcou 6EMHcy/bK8EP+QiksRha+ydkWyT/TVxJ29TjcpAcjcc3p2s8SyrCNq3fKt6LxLw4bOBS DwgA== X-Gm-Message-State: AOJu0YyNWRaT8qWnCGE/Afab8bsHkKW8kekaWlOxbGql8CY/L93iVd1O 9GVdKK6Z78VwdbahApoGt/l2TPYcPy+nEjy9Izh/u9wPjs7tuKkevVHkXIlWH1M= X-Google-Smtp-Source: AGHT+IHV6GaKXHNCkoA4zPQtCf/BXs58H6nmWQupzcXJs+pFzHTxNVQD3FC8Qak4VmK6OdZr0R4qqg== X-Received: by 2002:a17:90a:f989:b0:2d3:c976:dd80 with SMTP id 98e67ed59e1d1-2e0b8ee02admr111057a91.39.1727365356836; Thu, 26 Sep 2024 08:42:36 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e1bb004sm3684740a91.19.2024.09.26.08.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 08:42:35 -0700 (PDT) Date: Thu, 26 Sep 2024 08:42:32 -0700 From: Joe Damato To: Simon Horman Cc: netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:Hyper-V/Azure CORE AND DRIVERS" , open list Subject: Re: [RFC net-next 1/1] hv_netvsc: Link queues to NAPIs Message-ID: Mail-Followup-To: Joe Damato , Simon Horman , netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:Hyper-V/Azure CORE AND DRIVERS" , open list References: <20240924234851.42348-1-jdamato@fastly.com> <20240924234851.42348-2-jdamato@fastly.com> <20240926151024.GE4029621@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240926151024.GE4029621@kernel.org> On Thu, Sep 26, 2024 at 04:10:24PM +0100, Simon Horman wrote: > On Tue, Sep 24, 2024 at 11:48:51PM +0000, Joe Damato wrote: > > Use netif_queue_set_napi to link queues to NAPI instances so that they > > can be queried with netlink. > > > > Signed-off-by: Joe Damato > > --- > > drivers/net/hyperv/netvsc.c | 11 ++++++++++- > > drivers/net/hyperv/rndis_filter.c | 9 +++++++-- > > 2 files changed, 17 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c > > index 2b6ec979a62f..ccaa4690dba0 100644 > > --- a/drivers/net/hyperv/netvsc.c > > +++ b/drivers/net/hyperv/netvsc.c > > @@ -712,8 +712,11 @@ void netvsc_device_remove(struct hv_device *device) > > for (i = 0; i < net_device->num_chn; i++) { > > /* See also vmbus_reset_channel_cb(). */ > > /* only disable enabled NAPI channel */ > > - if (i < ndev->real_num_rx_queues) > > + if (i < ndev->real_num_rx_queues) { > > + netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_TX, NULL); > > + netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_RX, NULL); > > Hi Joe, > > When you post a non-RFC version of this patch, could you consider > line-wrapping the above to 80 columns, as is still preferred for > Networking code? > > There is an option to checkpatch that will warn you about this. Thanks for letting me know. I run checkpatch.pl --strict and usually it seems to let me know if I am over 80, but maybe there's another option I need?