* [PATCH] selftests: netfilter: Add missing resturn value.
@ 2024-09-27 3:22 zhangjiao2
2024-09-27 11:54 ` Phil Sutter
2024-09-27 11:58 ` Pablo Neira Ayuso
0 siblings, 2 replies; 4+ messages in thread
From: zhangjiao2 @ 2024-09-27 3:22 UTC (permalink / raw)
To: pablo
Cc: kadlec, davem, edumazet, kuba, pabeni, shuah, netfilter-devel,
coreteam, netdev, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
There is no return value in count_entries, just add it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/net/netfilter/conntrack_dump_flush.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
index bd9317bf5ada..dc056fec993b 100644
--- a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
+++ b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
@@ -207,6 +207,7 @@ static int conntrack_data_generate_v6(struct mnl_socket *sock,
static int count_entries(const struct nlmsghdr *nlh, void *data)
{
reply_counter++;
+ return MNL_CB_OK;
}
static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone)
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selftests: netfilter: Add missing resturn value.
2024-09-27 3:22 [PATCH] selftests: netfilter: Add missing resturn value zhangjiao2
@ 2024-09-27 11:54 ` Phil Sutter
2024-09-27 12:04 ` Pablo Neira Ayuso
2024-09-27 11:58 ` Pablo Neira Ayuso
1 sibling, 1 reply; 4+ messages in thread
From: Phil Sutter @ 2024-09-27 11:54 UTC (permalink / raw)
To: zhangjiao2
Cc: pablo, kadlec, davem, edumazet, kuba, pabeni, shuah,
netfilter-devel, coreteam, netdev
On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no return value in count_entries, just add it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Typo in $subject: resturn -> return
Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")
Apart from that:
Acked-by: Phil Sutter <phil@nwl.cc>
Thanks, Phil
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests: netfilter: Add missing resturn value.
2024-09-27 11:54 ` Phil Sutter
@ 2024-09-27 12:04 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2024-09-27 12:04 UTC (permalink / raw)
To: Phil Sutter, zhangjiao2, kadlec, davem, edumazet, kuba, pabeni,
shuah, netfilter-devel, coreteam, netdev
On Fri, Sep 27, 2024 at 01:54:11PM +0200, Phil Sutter wrote:
> On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> >
> > There is no return value in count_entries, just add it.
> >
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Typo in $subject: resturn -> return
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")
I amended this already, I found the same issues .
> Apart from that:
>
> Acked-by: Phil Sutter <phil@nwl.cc>
But I pushed it out already without your tag, thanks for reviewing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: netfilter: Add missing resturn value.
2024-09-27 3:22 [PATCH] selftests: netfilter: Add missing resturn value zhangjiao2
2024-09-27 11:54 ` Phil Sutter
@ 2024-09-27 11:58 ` Pablo Neira Ayuso
1 sibling, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2024-09-27 11:58 UTC (permalink / raw)
To: zhangjiao2
Cc: kadlec, davem, edumazet, kuba, pabeni, shuah, netfilter-devel,
coreteam, netdev
On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no return value in count_entries, just add it.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-27 12:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 3:22 [PATCH] selftests: netfilter: Add missing resturn value zhangjiao2
2024-09-27 11:54 ` Phil Sutter
2024-09-27 12:04 ` Pablo Neira Ayuso
2024-09-27 11:58 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).