From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>,
zhangjiao2 <zhangjiao2@cmss.chinamobile.com>,
kadlec@netfilter.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] selftests: netfilter: Add missing resturn value.
Date: Fri, 27 Sep 2024 14:04:02 +0200 [thread overview]
Message-ID: <ZvafMpchvuSt1MvY@calendula> (raw)
In-Reply-To: <Zvac4_L4THVtPv3g@orbyte.nwl.cc>
On Fri, Sep 27, 2024 at 01:54:11PM +0200, Phil Sutter wrote:
> On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> >
> > There is no return value in count_entries, just add it.
> >
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Typo in $subject: resturn -> return
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")
I amended this already, I found the same issues .
> Apart from that:
>
> Acked-by: Phil Sutter <phil@nwl.cc>
But I pushed it out already without your tag, thanks for reviewing.
next prev parent reply other threads:[~2024-09-27 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 3:22 [PATCH] selftests: netfilter: Add missing resturn value zhangjiao2
2024-09-27 11:54 ` Phil Sutter
2024-09-27 12:04 ` Pablo Neira Ayuso [this message]
2024-09-27 11:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvafMpchvuSt1MvY@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=shuah@kernel.org \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).