[PATCH] selftests: netfilter: Add missing resturn value.

[PATCH] selftests: netfilter: Add missing resturn value.

[zhangjiao2]

From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

There is no return value in count_entries, just add it.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/testing/selftests/net/netfilter/conntrack_dump_flush.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
index bd9317bf5ada..dc056fec993b 100644
--- a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
+++ b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
@@ -207,6 +207,7 @@ static int conntrack_data_generate_v6(struct mnl_socket *sock,
 static int count_entries(const struct nlmsghdr *nlh, void *data)
 {
 	reply_counter++;
+	return MNL_CB_OK;
 }
 
 static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone)
-- 
2.33.0

Re: [PATCH] selftests: netfilter: Add missing resturn value.

[Phil Sutter]

On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is no return value in count_entries, just add it.
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>

Typo in $subject: resturn -> return
Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")

Apart from that:

Acked-by: Phil Sutter <phil@nwl.cc>

Thanks, Phil

Re: [PATCH] selftests: netfilter: Add missing resturn value.

[Pablo Neira Ayuso]

On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is no return value in count_entries, just add it.

Applied, thanks

Re: [PATCH] selftests: netfilter: Add missing resturn value.

[Pablo Neira Ayuso]

On Fri, Sep 27, 2024 at 01:54:11PM +0200, Phil Sutter wrote:
> On Fri, Sep 27, 2024 at 11:22:05AM +0800, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > 
> > There is no return value in count_entries, just add it.
> > 
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> Typo in $subject: resturn -> return
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")

I amended this already, I found the same issues .

> Apart from that:
> 
> Acked-by: Phil Sutter <phil@nwl.cc>

But I pushed it out already without your tag, thanks for reviewing.