From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v3 09/12] selftests: ncdevmem: Remove hard-coded queue numbers
Date: Mon, 14 Oct 2024 07:47:35 -0700 [thread overview]
Message-ID: <Zw0vByssO2j6wfxI@mini-arch> (raw)
In-Reply-To: <CAHS8izPh7kwnvQtxwqGxka_rOe0fB21R7B167j2guJXkve9_bg@mail.gmail.com>
On 10/12, Mina Almasry wrote:
> On Wed, Oct 9, 2024 at 10:13 AM Stanislav Fomichev <sdf@fomichev.me> wrote:
> >
> > Use single last queue of the device and probe it dynamically.
> >
>
> Sorry I thought agreed that multi-queue binding test coverage is important.
>
> Can you please leave the default of num_queues to be 8 queues, or
> rxq_num / 2? You can override num_queues to 1 in your test invocations
> if you want. I would like by default an unaware tester that doesn't
> set num_queues explicitly to get multi-queue test coverage.
I might have misunderstood the agreement :-) I though you were ok with
the following arrangement:
1. use num_queues / 2 in the selftest mode to make sure binding to multiple
queues works (and this gets exercised from the python kselftest)
2. use single queue for the actual data path test (since we are
installing single flow steering rule, having multiple queues here is
confusing)
The num_queues / 2 part is here:
https://lore.kernel.org/netdev/20241009171252.2328284-11-sdf@fomichev.me/
Anything I'm missing?
next prev parent reply other threads:[~2024-10-14 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241009171252.2328284-1-sdf@fomichev.me>
[not found] ` <20241009171252.2328284-6-sdf@fomichev.me>
2024-10-13 3:47 ` [PATCH net-next v3 05/12] selftests: ncdevmem: Remove default arguments Mina Almasry
2024-10-14 14:53 ` Stanislav Fomichev
[not found] ` <20241009171252.2328284-10-sdf@fomichev.me>
2024-10-13 3:50 ` [PATCH net-next v3 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Mina Almasry
2024-10-14 14:47 ` Stanislav Fomichev [this message]
2024-10-14 22:49 ` Mina Almasry
[not found] ` <20241009171252.2328284-11-sdf@fomichev.me>
2024-10-14 22:47 ` [PATCH net-next v3 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw0vByssO2j6wfxI@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox