* [PATCH v2 net-next] selftests: tc-testing: Fixed Typo error
@ 2024-10-14 16:50 Karan Sanghavi
2024-10-14 23:57 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Karan Sanghavi @ 2024-10-14 16:50 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, netdev, linux-kselftest,
linux-kernel, Shuah Khan
Cc: Karan Sanghavi
This commit combines two fixes for typographical errors
in the "name" fields of the JSON objects with IDs
"4319" and "4341" in the tc-testing selftests.
For the files tc-tests/filters/cgroup.json and
/tc-tests/filters/flow.json.
v2:
- Combine two earlier patches into one
- Links to v1 of each patch
[1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
[2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/
Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
index 03723cf84..6897ff5ad 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
@@ -1189,7 +1189,7 @@
},
{
"id": "4319",
- "name": "Replace cgroup filter with diffferent match",
+ "name": "Replace cgroup filter with different match",
"category": [
"filter",
"cgroup"
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
index 58189327f..996448afe 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
@@ -507,7 +507,7 @@
},
{
"id": "4341",
- "name": "Add flow filter with muliple ops",
+ "name": "Add flow filter with multiple ops",
"category": [
"filter",
"flow"
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next] selftests: tc-testing: Fixed Typo error
2024-10-14 16:50 [PATCH v2 net-next] selftests: tc-testing: Fixed Typo error Karan Sanghavi
@ 2024-10-14 23:57 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-10-14 23:57 UTC (permalink / raw)
To: Karan Sanghavi, Jamal Hadi Salim, Cong Wang, Jiri Pirko, netdev,
linux-kselftest, linux-kernel
Cc: Karan Sanghavi, Shuah Khan
On 10/14/24 10:50, Karan Sanghavi wrote:
> This commit combines two fixes for typographical errors
> in the "name" fields of the JSON objects with IDs
> "4319" and "4341" in the tc-testing selftests.
> For the files tc-tests/filters/cgroup.json and
> /tc-tests/filters/flow.json.
>
This is not the correct way to write change logs. There is no
need to mention how two commits are combines.
State the problem and sya what this patch does e.g:
"Fix spelling errors in cgroup.json and flow.json"
> v2:
> - Combine two earlier patches into one
> - Links to v1 of each patch
> [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
> [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/
>
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
> tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> index 03723cf84..6897ff5ad 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> @@ -1189,7 +1189,7 @@
> },
> {
> "id": "4319",
> - "name": "Replace cgroup filter with diffferent match",
> + "name": "Replace cgroup filter with different match",
> "category": [
> "filter",
> "cgroup"
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> index 58189327f..996448afe 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> @@ -507,7 +507,7 @@
> },
> {
> "id": "4341",
> - "name": "Add flow filter with muliple ops",
> + "name": "Add flow filter with multiple ops",
> "category": [
> "filter",
> "flow"
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-14 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 16:50 [PATCH v2 net-next] selftests: tc-testing: Fixed Typo error Karan Sanghavi
2024-10-14 23:57 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).