Re: [PATCH net-next v2] net: airoha: Implement BQL support

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

> On Tue, 15 Oct 2024 17:54:59 +0200 Lorenzo Bianconi wrote:
> > > Oh, thought its called on stop. In that case we're probably good
> > > from BQL perspective.
> > > 
> > > But does it mean potentially very stale packets can sit on the Tx
> > > ring when the device is stopped, until it's started again?  
> > 
> > Do you mean the packets that the stack is transmitting when the .ndo_stop()
> > is run?
> 
> Whatever is in the queue at the time ndo_stop() gets called.
> Could be the full descriptor ring I presume?
> 
> > In airoha_dev_stop() we call netif_tx_disable() to disable the transmission
> > on new packets and inflight packets will be consumed by the completion napi,
> > is it not enough?
> 
> They will only get consumed if the DMA gets to them right?
> Stop seems to stop the DMA.
> 
> > I guess we can even add netdev_tx_reset_subqueue() for all netdev
> > queues in airoha_dev_stop(), I do not have a strong opinion about it. What
> > do you prefer?
> 
> So to be clear I think this patch is correct as of the current driver
> code. I'm just wondering if we should call airoha_qdma_cleanup_tx_queue()
> on stop as well, and then that should come with the reset.
> I think having a packet stuck in a queue may lead to all sort of oddness
> so my recommendation would be to flush the queues.

ack, I will post a fix for this. Do you prefer to resend even this patch? Up to you.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]